Re: [PHPUnit] #119: Testing with mock objects fail if an object does not allow cloning.

#119: Testing with mock objects fail if an object does not allow cloning.
-----------------------+----------------------------------------------------
   Reporter:  lomat    |       Owner:  sb          
       Type:  defect   |      Status:  assigned    
   Priority:  major    |   Milestone:  PHPUnit 3.1 
  Component:  phpunit  |     Version:  3.0.6       
 Resolution:           |    Keywords:  Mock Objects
Php_version:  5.2.0    |  
-----------------------+----------------------------------------------------
Comment (by sb):

 Replying to [comment:2 sb]:
 > Please test with the patch below:

 Correct patch:

 {{{
 Index: Framework/MockObject/Invocation.php
 ===================================================================
 --- Framework/MockObject/Invocation.php (revision 612)
 +++ Framework/MockObject/Invocation.php (working copy)
 @@ -87,7 +87,7 @@

          foreach ($this->parameters as $key => $value) {
              if (is_object($value)) {
 -                $this->parameters[$key] = clone $value;
 +                $this->parameters[$key] = $this->cloneObject($value);
              }
          }
      }
 @@ -111,5 +111,28 @@
            )
          );
      }
 +
 +    protected function cloneObject($original)
 +    {
 +        $object = new ReflectionObject($original);
 +
 +        if ($object->hasMethod('__clone')) {
 +            $method = $object->getMethod('__clone');
 +
 +            if (!$method->isPublic()) {
 +                return $original;
 +            }
 +
 +            try {
 +                return clone $original;
 +            }
 +
 +            catch (Exception $e) {
 +                return $original;
 +            }
 +        }
 +
 +        return clone $original;
 +    }
  }
  ?>
 }}}

-- 
Ticket URL: <http://www.phpunit.de/ticket/119#comment:3>
PHPUnit <http://www.phpunit.de/>