Re: cvs: pecl /apc apc_pthreadmutex.c pgsql_s_lock.h

Terribly sorry, corrected.

On Feb 16, 2007, at 9:33 AM, Magnus Määttä wrote:

> Hi Brian,
>
> On Thursday 15 February 2007, Brian Shire wrote:
> > shire           Thu Feb 15 21:40:45 2007 UTC
> >
> >   Modified files:
> >     /pecl/apc   apc_pthreadmutex.c pgsql_s_lock.h
> >   Log:
> >   fixing comments in pthread and spin locking (c++ style)
> > http://cvs.php.net/viewvc.cgi/pecl/apc/pgsql_s_lock.h? 
> > r1=3.1&r2=3.2&diff_format=u
> > Index: pecl/apc/pgsql_s_lock.h
> > diff -u pecl/apc/pgsql_s_lock.h:3.1 pecl/apc/pgsql_s_lock.h:3.2
> > --- pecl/apc/pgsql_s_lock.h:3.1 Mon Jan 29 07:39:02 2007
> > +++ pecl/apc/pgsql_s_lock.h     Thu Feb 15 21:40:45 2007
> > @@ -19,7 +19,7 @@
> >
> >   */
> >
> > -/* $Id: pgsql_s_lock.h,v 3.1 2007/01/29 07:39:02 shire Exp $ */
> > +/* $Id: pgsql_s_lock.h,v 3.2 2007/02/15 21:40:45 shire Exp $ */
> >
> >  / 
> > *-------------------------------------------------------------------- 
> > -----
> >   *
> > @@ -125,9 +125,9 @@
> >                 "  instruction     \n"
> >                 "  instruction     \n"
> >                 "  instruction     \n"
> > -:              "=r"(_res), "+m"(*lock)             // return register, in/out 
> > lock value
> > -:              "r"(lock)                                     // lock pointer, 
> > in input register
> > -:              "memory", "cc");                    // show clobbered registers 
> > here
> > +:              "=r"(_res), "+m"(*lock)             /* return register, in/out 
> > lock value */
> > +:              "r"(lock)                                     /* lock pointer, 
> > in input register */
> > +:              "memory", "cc");                    /* show clobbered registers 
> > here */
> >
> >   * The output-operands list (after first colon) should always  
> > include
> >   * "+m"(*lock), whether or not the asm code actually refers to this
> This broke compilation here since those are comments inside another
> C-style comment. and the */ ends it.
>
>
> Regards,
> Magnus Määttä
>
> --
> Atlanta makes it against the law to tie a giraffe to a telephone pole
> or street lamp.
>
> --
> PECL CVS Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
-Brian Shire
 shire@xxxxxxxxxxxx
 shire@xxxxxxx