cvs: pecl /http http_request_pool_api.c http_requestpool_object.c

mike            Fri Oct 28 07:49:15 2005 EDT

  Modified files:              
    /pecl/http  http_request_pool_api.c http_requestpool_object.c 
  Log:
  - all those handlers->add_ref(zobject) would prevent the objects from
    being freed when there's no more reference to them
  
http://cvs.php.net/diff.php/pecl/http/http_request_pool_api.c?r1=1.21&r2=1.22&ty=u
Index: pecl/http/http_request_pool_api.c
diff -u pecl/http/http_request_pool_api.c:1.21 
pecl/http/http_request_pool_api.c:1.22
--- pecl/http/http_request_pool_api.c:1.21      Fri Oct 28 06:51:10 2005
+++ pecl/http/http_request_pool_api.c   Fri Oct 28 07:49:13 2005
@@ -10,7 +10,7 @@
     +--------------------------------------------------------------------+
 */
 
-/* $Id: http_request_pool_api.c,v 1.21 2005/10/28 10:51:10 mike Exp $ */
+/* $Id: http_request_pool_api.c,v 1.22 2005/10/28 11:49:13 mike Exp $ */
 
 #ifdef HAVE_CONFIG_H
 #      include "config.h"
@@ -103,7 +103,6 @@
                                zend_llist_add_element(&pool->bodies, &body);
 
                                ZVAL_ADDREF(request);
-                               Z_OBJ_ADDREF_P(request);
 
 #if HTTP_DEBUG_REQPOOLS
                                fprintf(stderr, "> %d HttpRequests attached to 
pool %p\n", zend_llist_count(&pool->handles), pool);
@@ -310,7 +309,6 @@
 #endif
                
                ZVAL_ADDREF(*req);
-               Z_OBJ_ADDREF_PP(req);
                zend_llist_add_element(&obj->pool->finished, req);
                http_request_object_responsehandler(obj, *req);
        }
http://cvs.php.net/diff.php/pecl/http/http_requestpool_object.c?r1=1.25&r2=1.26&ty=u
Index: pecl/http/http_requestpool_object.c
diff -u pecl/http/http_requestpool_object.c:1.25 
pecl/http/http_requestpool_object.c:1.26
--- pecl/http/http_requestpool_object.c:1.25    Tue Oct 25 08:01:30 2005
+++ pecl/http/http_requestpool_object.c Fri Oct 28 07:49:13 2005
@@ -10,7 +10,7 @@
     +--------------------------------------------------------------------+
 */
 
-/* $Id: http_requestpool_object.c,v 1.25 2005/10/25 12:01:30 mike Exp $ */
+/* $Id: http_requestpool_object.c,v 1.26 2005/10/28 11:49:13 mike Exp $ */
 
 
 #ifdef HAVE_CONFIG_H
@@ -148,7 +148,6 @@
 static void _http_requestpool_object_llist2array(zval **req, zval *array 
TSRMLS_DC)
 {
        ZVAL_ADDREF(*req);
-       Z_OBJ_ADDREF_PP(req);
        add_next_index_zval(array, *req);
 }