cvs: pearweb /public_html/bugs bug.php

cellog          Sun Mar 25 00:29:46 2007 UTC

  Modified files:              
    /pearweb/public_html/bugs   bug.php 
  Log:
  tweak last commit a bit
  
http://cvs.php.net/viewvc.cgi/pearweb/public_html/bugs/bug.php?r1=1.141&r2=1.142&diff_format=u
Index: pearweb/public_html/bugs/bug.php
diff -u pearweb/public_html/bugs/bug.php:1.141 
pearweb/public_html/bugs/bug.php:1.142
--- pearweb/public_html/bugs/bug.php:1.141      Sun Mar 25 00:13:27 2007
+++ pearweb/public_html/bugs/bug.php    Sun Mar 25 00:29:46 2007
@@ -15,7 +15,7 @@
  * @package   Bugs
  * @copyright Copyright (c) 1997-2005 The PHP Group
  * @license   http://www.php.net/license/3_0.txt  PHP License
- * @version   $Id: bug.php,v 1.141 2007/03/25 00:13:27 davidc Exp $
+ * @version   $Id: bug.php,v 1.142 2007/03/25 00:29:46 cellog Exp $
  */
 
 /*
@@ -634,6 +634,7 @@
         $db = Bug_DataObject::bugDB('bugdb_roadmap');
         $db->package = $bug['package_name'];
         $db->orderBy('releasedate DESC');
+        $assignedRoadmap = array();
         if ($db->find(false)) {
             while ($db->fetch()) {
                 $released = $dbh->getOne('SELECT releases.id
@@ -644,11 +645,11 @@
                     releases.version=b.roadmap_version',
                     array($db->id));
                 if (isset($links[$db->id])) {
-                                       $url = '/bugs/roadmap.php?package=' . 
$db->package . 
-                                                  '&roadmapdetail=' . 
$db->roadmap_version .
-                                                  '#a' . $db->roadmap_version;
-                                       
-                    $assignedRoadmap[$url] = $db->roadmap_version;
+                                       $assignedRoadmap[] = '<a 
href="/bugs/roadmap.php?package=' .
+                                       $db->package . ($released ? 
'&showold=1' : '') .
+                                       '&roadmapdetail=' . 
$db->roadmap_version .
+                                               '#a' . $db->roadmap_version . 
'">' . $db->roadmap_version .
+                                               '</a>';
                 }
             }
         } else {
@@ -660,23 +661,7 @@
 
    <td>
    <?php
-    $i        = 0;
-    $maxValue = count($assignedRoadmap) - 1;
-       
-    foreach ($assignedRoadmap as $roadmap => $key) {
-               /**
-                * @todo remove this and store that into a template when 
-                *       we decide to move everythign to templates in this file.
-                *       I could make it include this part but that's gonna be
-                *       wasting time for nothing as later is going to be easier
-                *               to just move everything to templates.
-                */
-        echo '<a href="' . $roadmap . '">' . $key . '</a>';
-               if ($i < $maxValue) {
-                       echo ', ';
-               }
-               ++$i;
-    }
+    echo implode(', ', $assignedRoadmap);
    ?>
    </td>
    <th>&nbsp;</th>

-- 
PEAR CVS Mailing List (http://pear.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php