logo       

[bug] read more links broken if filters are in action: msg#01062

php.drupal.devel

Subject: [bug] read more links broken if filters are in action

Project: Drupal
Version: cvs
Component: node.module
Category: bug reports
Priority: critical
Assigned to: Anonymous
Reported by: Goba
Updated by: Goba
Status: patch
Attachment: http://drupal.org/files/issues/Drupal-readmore-fix.patch (871
bytes)

The node module was modified to only filter what is needed. That way we
got rid of a lot of unneeded filter processing. But now if I have a
node with identical teaser and body, when a taxonomy page is viewed
(only teasers), only the teaser will be filtered, so the body and
teaser will be different at the time Drupal hits the check whether they
are the same... This results in read more links displayed, if at least
one filter have modified the teaser.

A solution would be to check the equivalence earlier or keep a copy of
the original teaser for reference. I opted for checking the equivalence
earlier, since that means a lot less overhead and also a small piece of
data to build theme magic from if need be :) See the attached patch.

Goba

--
View: http://drupal.org/node/view/6140
Edit: http://drupal.org/project/comments/add/6140





<Prev in Thread] Current Thread [Next in Thread>
Google Custom Search

News | FAQ | advertise