Re: Locale.module improvements of Gerhard

On Sun, 29 Feb 2004, Stefan Nagtegaal wrote:

> > A module compatible to cvs. Just create the tables from locale.mysql and
> > replace the existing one.
> Replace the existing ones? So, that means that I'm probably loosing my whole
> built-up and translated locales table as it is now?

Sorry, I meant to say "replace the existing module".

> That doesn't sound as 'music' in my ears.. Can't we write an update-script
> for this? Or am I getting you wrong?

Well, yes. You cannot use your translations for the time being, but you
will not lose them. I will write a script that moves old translations to
the new tables.

> > You need also to aply the patches in common-plural.patch. I'll update
> > them if they should not apply anymore.
> I took a look at your patches, they look good.. Very interesting
> study-material!

I hope that Dries likes them as well...

> > > - Does it work?
> > Everything but the PO and POT file download should work.
> So, why should I use it then? These are kind a critical things that don't
> work..
> Kind a pitty...

The most important part is PO upload. You take drupal.pot, create an
empty PO file for your language from it, translate as much as possible,
and upload it. If you have translated more strings, upload the file
again, the translations will be updated.

The PO download and POT download is not that important. It is only
convenient if you should want to maintain the translations of an
existing site where you have a lot of contrib modules and don't want
multiple PO files.
The authoritative sources for strings to translate will be
drupal.pot and <module>.pot.

If you already have a PO file for your language (from localegettext for
example), you can use the gettext tools to merge existing entries into a
new empty <language>.po file.

I can do that for you, too. Just upload your PO file to
contrib/translations/po.

> > > I would be happy to test and report/fix bugs, because this module really
> > > needs some work..
> > I hope the majority of the work is done. Since Dries wanted me to change
> > the database structure as well it is nearly a rewrite. Due to this it
> > won't make it for 4.4., but I will provide a contrib module.

> Why a contrib-module? Why can't these chages hit the core? The
> locales.module really needs work as said y Dries already months ago. Can't
> we get this inside the core by changing some code or giving this some more
> thought first? Dries?

The point is that it is nearly a complete rewrite due to the database
changes and it is not well enough tested.

A (maintained!) contrib module does not have to be bad. During the bug
fixing period I can also fix bugs easier as I don't have to bug Dries
with patches.

Cheers,
        Gerhard