[bug] broken taxonomy_overview() function

Project:      Drupal
Version:      cvs
Component:    taxonomy.module
Category:     bug reports
Priority:     normal
Assigned to:  spiderman
Reported by:  spiderman
Updated by:   Dries
Status:       patch

Please attach your patch using the 'file attachment' form.  Thanks.  How
can we trigger/reproduce this problem?

Dries



Previous comments:
------------------------------------------------------------------------

February 9, 2004 - 03:48 : spiderman

i think this bug has existed since 4.3.0, where the taxonomy_overview
function does not generate the table data correctly for vocabularies
assigned to multiple node types.  this patch corrects the problem.

[?php
--- ../drupal-4.3.2/modules/taxonomy.module     2003-10-22
09:03:32.000000000 -0400
+++ modules/taxonomy.module     2004-02-08 21:45:49.000000000 -0500
@@ -277,7 +277,13 @@

  foreach ($vocabularies as $vocabulary) {
    $links = array();
-    $rows[] = array($vocabulary->name, array("data" =>
module_invoke($vocabulary->nodes, "node", "name"), "align" =>
"center"), l(t("edit vocabulary"),
"admin/taxonomy/edit/vocabulary/$vocabulary->vid"), l(t("add term"),
"admin/taxonomy/add/term/$vocabulary->vid"), l(t("preview form"),
"admin/taxonomy/preview/vocabulary/$vocabulary->vid"));
+
+    # build a list of node types
+    $types = array();
+    foreach (explode(",",$vocabulary->nodes) as $type) {
+       $types[] = module_invoke($type,"node","name") . $sep;
+    }
+    $rows[] = array($vocabulary->name, array("data" =>
implode(",",$types), "align" => "center"), l(t("edit vocabulary"),
"admin/taxonomy/edit/vocabulary/$vocabulary->vid"), l(t("add term"),
"admin/taxonomy/add/term/$vocabulary->vid"), l(t("preview form"),
"admin/taxonomy/preview/vocabulary/$vocabulary->vid"));

    $tree = taxonomy_get_tree($vocabulary->vid);
    if ($tree) {

?]

------------------------------------------------------------------------

February 9, 2004 - 04:22 : weitzman@xxxxxxxxxxxx

This is indeed a bug. However, the review team only considers patches
against CVS Drupal. The node system has changed enough that your patch
no longer applies. Please consider resubmitting.

------------------------------------------------------------------------

February 12, 2004 - 15:38 : spiderman

ok here's a new patch, against today's cvs version of taxonomy.module:

[?php
--- drupal/modules/taxonomy.module      Thu Feb 12 09:33:59 2004
+++ patch/taxonomy.module       Thu Feb 12 09:37:34 2004
@@ -284,7 +284,14 @@
    foreach(explode(",", $vocabulary->nodes) as $type) {
      $types[] = node_invoke($type, "node_name");
    }
-    $rows[] = array($vocabulary->name, array("data" => implode(", ",
$types), "align" => "center"), l(t("edit vocabulary"),
"admin/taxonomy/edit/vocabulary/$vocabulary->vid"), l(t("add term"),
"admin/taxonomy/add/term/$vocabulary->vid"), l(t("preview form"),
"admin/taxonomy/preview/vocabulary/$vocabulary->vid"));
+
+    # build a list of node types
+    $types = array();
+    foreach (explode(",",$vocabulary->nodes) as $type) {
+       $types[] = module_invoke($type,"node","name") . $sep;
+    }
+    $rows[] = array($vocabulary->name, array("data" =>
implode(",",$types), "align" => "center"), l(t("edit vocabulary"),
"admin/taxonomy/edit/vocabulary/$vocabulary->vid"), l(t("add term"),
"admin/taxonomy/add/term/$vocabulary->vid"), l(t("preview form"),
"admin/taxonomy/preview/vocabulary/$vocabulary->vid"));
+
 
    $tree = taxonomy_get_tree($vocabulary->vid);
    if ($tree) {
?]

------------------------------------------------------------------------

February 12, 2004 - 20:06 : Dries

Please attach your patch using the 'file attachment' form.  Thanks.

--
View: http://drupal.org/node/view/5740
Edit: http://drupal.org/project/comments/add/5740