Re: cvs: ZendEngine2(PHP_5_1) / zend_operators.c

This seems more like a hack to fix bugs elsewhere.
My main problem is that this changes behavior and requires this 
function to be used on null-terminated strings. So now it doesn't 
work for substrings nor in situations where it might not be null-terminated.
Please revert this patch and fix the place which is calling it incorrectly.

Thanks.

At 11:10 AM 12/12/2005, Marcus Boerger wrote:
> helly           Mon Dec 12 19:10:13 2005 EDT
>
>   Modified files:              (Branch: PHP_5_1)
>     /ZendEngine2        zend_operators.c
>   Log:
>   - Enforce termination to prevent possible SEGVs
>
> http://cvs.php.net/viewcvs.cgi/ZendEngine2/zend_operators.c?r1=1.208.2.1&r2=1.208.2.2&diff_format=u
> Index: ZendEngine2/zend_operators.c
> diff -u ZendEngine2/zend_operators.c:1.208.2.1 
> ZendEngine2/zend_operators.c:1.208.2.2
> --- ZendEngine2/zend_operators.c:1.208.2.1      Mon Sep 12 11:48:56 2005
> +++ ZendEngine2/zend_operators.c        Mon Dec 12 19:10:12 2005
> @@ -17,7 +17,7 @@
>     +----------------------------------------------------------------------+
>  */
>
> -/* $Id: zend_operators.c,v 1.208.2.1 2005/09/12 11:48:56 dmitry Exp $ */
> +/* $Id: zend_operators.c,v 1.208.2.2 2005/12/12 19:10:12 helly Exp $ */
>
>  #include <ctype.h>
>
> @@ -1783,7 +1783,7 @@
>         while (str < end) {
>                 *result++ = tolower((int)*str++);
>         }
> -       *result = *end;
> +       *result = '\0';
>
>         return dest;
>  }
>
> --
> Zend Engine CVS Mailing List (http://cvs.php.net/)
> To unsubscribe, visit: http://www.php.net/unsub.php
--
Zend Engine CVS Mailing List (http://cvs.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php