cvs: pear /HTML_Common Common.php

mansion         Fri Sep 27 07:11:10 2002 EDT

  Modified files:              
    /pear/HTML_Common   Common.php 
  Log:
  As suggested by Niklas Neumann, use htmlentities instead of htmlspecialchars.
  + Some cleanup.
  
  
Index: pear/HTML_Common/Common.php
diff -u pear/HTML_Common/Common.php:1.2 pear/HTML_Common/Common.php:1.3
--- pear/HTML_Common/Common.php:1.2     Mon Jun  3 22:47:59 2002
+++ pear/HTML_Common/Common.php Fri Sep 27 07:11:10 2002
@@ -16,7 +16,7 @@
 // | Author: Adam Daniel <adaniel1@xxxxxxxxxxxxx>                         |
 // +----------------------------------------------------------------------+
 //
-// $Id: Common.php,v 1.2 2002/06/04 02:47:59 adaniel Exp $
+// $Id: Common.php,v 1.3 2002/09/27 11:11:10 mansion Exp $
 
 /**
  * Base class for all HTML classes
@@ -95,7 +95,7 @@
                 if (is_int($key)) {
                     $strAttr .= ' ' . strtolower($value) . '="' . 
strtolower($value) . '"';
                 } else {
-                    $strAttr .= ' ' . strtolower($key) . '="' . 
htmlspecialchars($value) . '"';
+                    $strAttr .= ' ' . strtolower($key) . '="' . 
htmlentities($value) . '"';
                 }
             }
         }
@@ -143,7 +143,7 @@
      * @since     1.0
      * @access    private
      * @return    array key
-     * @throws    
+     * @throws
      */
     function _getAttrKey($attr, $attributes)
     {
@@ -189,7 +189,7 @@
             }
         }
     } // end func _updateAtrrArray
-    
+
     /**
      * Removes the given attribute from the given array
      * 
@@ -198,7 +198,7 @@
      * @since     1.4
      * @access    public
      * @return    void
-     * @throws    
+     * @throws
      */
     function _removeAttr($attr, &$attributes)
     {
@@ -216,7 +216,7 @@
      * @since     1.5
      * @access    public
      * @return    void
-     * @throws    
+     * @throws
      */
     function getAttribute($attr)
     {
@@ -232,7 +232,7 @@
      * @param    mixed   $attributes     Either a typical HTML attribute 
string or an associative array
      * @access   public
      */
-    function setAttributes($attributes) 
+    function setAttributes($attributes)
     {
         $this->_attributes = $this->_parseAttributes($attributes);
     } // end func _setAttributes
@@ -243,7 +243,7 @@
      * @since     1.6
      * @access    public
      * @return    void
-     * @throws    
+     * @throws
      */
     function getAttributes()
     {
@@ -262,13 +262,13 @@
     } // end func updateAttributes
 
     /**
-     * Removes an attribute from 
+     * Removes an attribute
      * 
      * @param     string    $attr   Attribute name
      * @since     1.4
      * @access    public
      * @return    void
-     * @throws    
+     * @throws
      */
     function removeAttribute($attr)
     {
@@ -284,14 +284,14 @@
     {
         $this->_tabOffset = $offset;
     } // end func setTabOffset
-    
+
     /**
      * Returns the tabOffset
      * 
      * @since     1.5
      * @access    public
      * @return    void
-     * @throws    
+     * @throws
      */
     function getTabOffset()
     {
@@ -305,20 +305,20 @@
      * @since     1.4
      * @access    public
      * @return    void
-     * @throws    
+     * @throws
      */
     function setComment($comment)
     {
         $this->_comment = $comment;
     } // end func setHtmlComment
-    
+
     /**
      * Returns the HTML comment
      * 
      * @since     1.5
      * @access    public
      * @return    void
-     * @throws    
+     * @throws
      */
     function getComment()
     {
@@ -330,11 +330,11 @@
      *
      * @access    public
      * @return    string
-     * @abstract    
+     * @abstract
      */
     function toHtml()
     {
-        return "";
+        return '';
     } // end func toHtml
 
     /**



-- 
PEAR CVS Mailing List (http://pear.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php