Re: pb in parsing <link idref="123">foo</link>

Hi Archie,

thank you for your responds. I understand my "explications" could be a lot confusing, but I have a lot of difficults to explain in english.

so, I'm trying to play with the latest cvs version of cowiki...
But I got a lot of errors. The pb could come with PHP 5.0.5 and could not exists with PHP 5.0.4 (not verified)

The first error I got is "Fatal error: Only variables can be passed by reference in class.WikiReverseParser.php
 (873)"

The error seems to be easily solvable by replacing

if( $sName == end(array_keys($this->aAttrib)) ) {

by

if( $sName == end($foo = array_keys($this->aAttrib)) ) {


I got an other error when validating an edited document containing html (not very sure) tags:

Fatal error:  Maximum execution time of 30 seconds exceeded in /var/www/cowiki.new/includes/cowiki/class/parse/class.WikiParser.php on line 775

and an other error, but I can't determine exactly when it occurs:

Fatal error:  Call to a member function get() on a non-object in /var/www/cowiki.new/includes/cowiki/class/render/class.FrontHtmlTransformer.php on line 553

and an other one

Fatal error:  Maximum execution time of 30 seconds exceeded in /var/www/cowiki.new/includes/cowiki/class/parse/class.WikiParser.php
 on line 368

I hope it could help and I'm sorry if explainations are not very clear...

Thank you for your help.

On 5/5/06, Archie Campbell <cephalicmarble@xxxxxxxxxxxxxxxx> wrote:

Hi Raphael,

I'm the programmer working on aspects of the coWiki parse and display
mechanisms. Since 0.3.4, coWiki has been changed fairly drastically, and
we are still lacking thorough testing of the new code.

Suffice to say that the area you highlight has undergone some serious
alterations. What I'm trying to say is that 0.3.4 is not really
supported anymore, but that were you to (backup thoroughly and then...)
install the latest from CVS you might well find various problems
disappearing. Alternatively, you might become our next best bug-funder.

I'm confused by the patch that you report, which apparently changes the
code only by altering execution order and maybe by side-effects. I can't
quite grasp what you've changed to make a problem that I don't know
about go away, which is intrigueing!

Please stay in touch.

Archie

Raphael Letocart wrote:

> Hi guys,
>
> I've got problems with cowiki 0.3.4 with apache2 + php5
> (libapache2-mod-php5)
>
> I could'nt edit a document if it contains a "((My Document)(FOO))"
> link, "<link idref="123">foo</link>" in the database,
> but if the document contains only "((My Document))" all was good.
> So after a lot of search I found that
>
> "protected function buildIdRefLink(&$aMatches)" in
> class.CoWikiReverseParser.php was causing the pb,
> so I modified
>
>         // Generate normal link with an alias
>         return '('
>                  .'('
>                     .$sPrefix
>                     .$this->noopDelimiters(escape($RefNode->get('name')))
>                  .')'
>                  .'('
>                     .escape($aMatches[2])
>                  . ')'
>                .')';
>
>
> with
>
>
> $var1 = $RefNode->get('name');
> $var2 = escape($var1);
> $var3 = $this->noopDelimiters($var2);
>
> $ret = '('
>                  .'('
>                     .$sPrefix
>                     .$var3
>                  .')'
>                  .'('
>                     .escape($aMatches[2])
>                  . ')'
>                .')';
>
>         // Generate normal link with an alias
>         return $ret;
>
> Sorry for my very poor english. I hope it could help someone.