Subject: Re: [HACKERS] [COMMITTERS] pgsql: /home/peter/commit-msg - msg#00123

Previous Message by Date: click to view message preview

Re: [HACKERS] [COMMITTERS] pgsql: /home/peter/commit-msg

Heikki Linnakangas <heikki.linnakangas@xxxxxxxxxxxxxxxx> writes: > Magnus Hagander wrote: >> On Mon, Nov 16, 2009 at 08:29, David Fetter <david@xxxxxxxxxx> wrote: >>> On Mon, Nov 16, 2009 at 06:56:54AM +0200, Peter Eisentraut wrote: >>>> Yeah, sorry guys. I fixed the CVS log message now. >> So it's not only not strange, I'm very happy it didn't pull those >> changes and broke my repository :-) > Yeah, I'm glad it didn't do anything funny with the mirror. I think we should have a policy of NO manual changes to the CVS repository files. At least not without careful discussion beforehand. The lack of a commit message for this one small patch was absolutely not worth taking any risks to fix. regards, tom lane -- Sent via pgsql-committers mailing list (pgsql-committers@xxxxxxxxxxxxxx) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers

Next Message by Date: click to view message preview

[COMMITTERS] pgsql: While doing the final setrefs.c pass over a plan tree, try to

Log Message: ----------- While doing the final setrefs.c pass over a plan tree, try to match up non-Var sort/group expressions using ressortgroupref labels instead of depending entirely on equal()-ity of the upper node's tlist expressions to the lower node's. This avoids emitting the wrong outputs in cases where there are textually identical volatile sort/group expressions, as for example select distinct random(),random() from generate_series(1,10); Per report from Andrew Gierth. Backpatch to 8.4. Arguably this is wrong all the way back, but the only known case where there's an observable problem is when using hash aggregation to implement DISTINCT, which is new as of 8.4. So for the moment I'll refrain from backpatching further. Modified Files: -------------- pgsql/src/backend/optimizer/plan: setrefs.c (r1.154 -> r1.155) (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/optimizer/plan/setrefs.c?r1=1.154&r2=1.155) -- Sent via pgsql-committers mailing list (pgsql-committers@xxxxxxxxxxxxxx) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers

Previous Message by Thread: click to view message preview

Re: [HACKERS] [COMMITTERS] pgsql: /home/peter/commit-msg

Heikki Linnakangas <heikki.linnakangas@xxxxxxxxxxxxxxxx> writes: > Magnus Hagander wrote: >> On Mon, Nov 16, 2009 at 08:29, David Fetter <david@xxxxxxxxxx> wrote: >>> On Mon, Nov 16, 2009 at 06:56:54AM +0200, Peter Eisentraut wrote: >>>> Yeah, sorry guys. I fixed the CVS log message now. >> So it's not only not strange, I'm very happy it didn't pull those >> changes and broke my repository :-) > Yeah, I'm glad it didn't do anything funny with the mirror. I think we should have a policy of NO manual changes to the CVS repository files. At least not without careful discussion beforehand. The lack of a commit message for this one small patch was absolutely not worth taking any risks to fix. regards, tom lane -- Sent via pgsql-committers mailing list (pgsql-committers@xxxxxxxxxxxxxx) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers

Next Message by Thread: click to view message preview

Re: [HACKERS] [COMMITTERS] pgsql: /home/peter/commit-msg

2009/11/16 Peter Eisentraut <peter_e@xxxxxxx>: > On mån, 2009-11-16 at 10:05 -0500, Tom Lane wrote: >> Heikki Linnakangas <heikki.linnakangas@xxxxxxxxxxxxxxxx> writes: >> > Magnus Hagander wrote: >> >> On Mon, Nov 16, 2009 at 08:29, David Fetter <david@xxxxxxxxxx> wrote: >> >>> On Mon, Nov 16, 2009 at 06:56:54AM +0200, Peter Eisentraut wrote: >> >>>> Yeah, sorry guys.  I fixed the CVS log message now. >> >> >> So it's not only not strange, I'm very happy it didn't pull those >> >> changes and broke my repository :-) >> >> > Yeah, I'm glad it didn't do anything funny with the mirror. >> >> I think we should have a policy of NO manual changes to the CVS >> repository files.  At least not without careful discussion beforehand. > > I used cvs admin. I've cleaned up the git repo, and re-enabled the mirror script. From what I can tell it works fine. In theory you will need to use force mode if you pulled the broken commit that was removed (the one with the wrong message), but it seems this is not necessarily required. As for the future, please avoid doing any "cvs admin" activity if possible, and if it's done let's specifically coordinate with the git mirror script, to make sure things work smoothly. -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/ -- Sent via pgsql-committers mailing list (pgsql-committers@xxxxxxxxxxxxxx) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers