Subject: Re: Please review libxml++2 - msg#00005

Previous Message by Date: click to view message preview

Re: Please review esmtp

On Mon, Nov 07, 2005 at 09:09:45AM +0000, Leonard Schmidt wrote: > four months passed, and I still think that the package is ready for > pkgsrc. :-) > Can somebody import this into pkgsrc, please? Is there a particular reason the package has: .if !exists(/usr/bin/flex) BUILD_DEPENDS+= flex-[0-9]*:../../devel/flex .endif instead of USE_TOOLS+= flex Other than that, the package looks fine to me. Thomas ------------------------------------------------------- SF.Net email is sponsored by: Tame your development challenges with Apache's Geronimo App Server. Download it for free - -and be entered to win a 42" plasma tv or your very own Sony(tm)PSP. Click here to play: http://sourceforge.net/geronimo.php

Next Message by Date: click to view message preview

Re: wip/siproxd

On Sun, Apr 17, 2005 at 01:09:56AM +0200, Georg Schwarz wrote: > I have just committed wip/siproxd. Since I do not have much experince > with creating new packages I would appreciate if you could review the > Makefile and provide me with feedback (even if you are not interested in > the particular application, which is a SIP Application Level Gateway). The comment is very very short. At least ALG should be expanded. It shouldn't start with an article either (pkglint complains about it). > I am in particular interested in the use of PKG_SYSCONFDIR, > INSTALLATION_DIRS and the treatment of PLIST. > Also, should I better use ${LOCALBASE}/share/examples/siproxd for the > example config file? Should I use CONF_FILES? Yes, definitely. You should modify the package to install the files in ${PREFIX}/share/examples/siproxd and use CONF_FILES to copy them to PKG_SYSCONFDIR automatically. > Should I not use the original Makefile's install but rather install the > files myself using an explicit do-install: in my Makefile? Usually we try to use the package's Makefile, since it is easier during updates (you don't have to check manually if the package would want to install more files). > PS: watch out for wip/linphone which I have currently in the making... > literally... Comments for that: . use the inet6 option instead of USE_INET6 . BUILD_DEPENDS should come earlier (right after the COMMENT section, in an own section) . PKGMANDIR in the PLIST is unnecessary, just use "man" . The --with-html-dir configure argument should point to ${PREFIX}/share/doc/linphone . share/gnome/help/linphone are empty, so perhaps just remove them in a post-install step instead of adding them to the PLIST (they won't get create this way if you don't @exec ${MKDIR} them). I haven't tried compiling either of them yet. Cheers, Thomas ------------------------------------------------------- SF.Net email is sponsored by: Tame your development challenges with Apache's Geronimo App Server. Download it for free - -and be entered to win a 42" plasma tv or your very own Sony(tm)PSP. Click here to play: http://sourceforge.net/geronimo.php

Previous Message by Thread: click to view message preview

Re: Please review esmtp

On Mon, Nov 07, 2005 at 09:09:45AM +0000, Leonard Schmidt wrote: > four months passed, and I still think that the package is ready for > pkgsrc. :-) > Can somebody import this into pkgsrc, please? Is there a particular reason the package has: .if !exists(/usr/bin/flex) BUILD_DEPENDS+= flex-[0-9]*:../../devel/flex .endif instead of USE_TOOLS+= flex Other than that, the package looks fine to me. Thomas ------------------------------------------------------- SF.Net email is sponsored by: Tame your development challenges with Apache's Geronimo App Server. Download it for free - -and be entered to win a 42" plasma tv or your very own Sony(tm)PSP. Click here to play: http://sourceforge.net/geronimo.php

Next Message by Thread: click to view message preview

Re: wip/siproxd

On Sun, Apr 17, 2005 at 01:09:56AM +0200, Georg Schwarz wrote: > I have just committed wip/siproxd. Since I do not have much experince > with creating new packages I would appreciate if you could review the > Makefile and provide me with feedback (even if you are not interested in > the particular application, which is a SIP Application Level Gateway). The comment is very very short. At least ALG should be expanded. It shouldn't start with an article either (pkglint complains about it). > I am in particular interested in the use of PKG_SYSCONFDIR, > INSTALLATION_DIRS and the treatment of PLIST. > Also, should I better use ${LOCALBASE}/share/examples/siproxd for the > example config file? Should I use CONF_FILES? Yes, definitely. You should modify the package to install the files in ${PREFIX}/share/examples/siproxd and use CONF_FILES to copy them to PKG_SYSCONFDIR automatically. > Should I not use the original Makefile's install but rather install the > files myself using an explicit do-install: in my Makefile? Usually we try to use the package's Makefile, since it is easier during updates (you don't have to check manually if the package would want to install more files). > PS: watch out for wip/linphone which I have currently in the making... > literally... Comments for that: . use the inet6 option instead of USE_INET6 . BUILD_DEPENDS should come earlier (right after the COMMENT section, in an own section) . PKGMANDIR in the PLIST is unnecessary, just use "man" . The --with-html-dir configure argument should point to ${PREFIX}/share/doc/linphone . share/gnome/help/linphone are empty, so perhaps just remove them in a post-install step instead of adding them to the PLIST (they won't get create this way if you don't @exec ${MKDIR} them). I haven't tried compiling either of them yet. Cheers, Thomas ------------------------------------------------------- SF.Net email is sponsored by: Tame your development challenges with Apache's Geronimo App Server. Download it for free - -and be entered to win a 42" plasma tv or your very own Sony(tm)PSP. Click here to play: http://sourceforge.net/geronimo.php