Reviews wanted for ppp-lzs

Hi,
   Please review my ppp-lzs package. This is for NetBSD only currently and
I am running 1.6.1 here though other versions may work also (I dont think
pppd is changed). You need NetBSD source sets installed and to test the
build/install as it is basically a patch against the stock pppd (plus
kernel module for the compressor).

 In use you will have to have a PPP connection to the internet and one
that has Stac/LZS PPP compression available. In the UK, my ISP
(www.ukfsn.org) has it, as do several others (Aardvark and Club24 I
recall, though I dont use them anymore - I didnt have much problem finding
one that did anyway).  In use, I get compression ratios of 2-3 times so
thats good for me (since I have a 9600bps cellular link :)

I have a few queries:

   Currently this is installed to ${PREFIX}/bin etc, but since this is a
replacement for the system version, should I overwrite the system version
so that it gets used?  Maybe a note in the MESSAGE file that you need to
be aware that there are two versions on the system?

   The other thing is that it provides a lkm - should this be installed in
${PREFIX}/lkm as currently happens, or should it go to /usr/lkm with all
the other system modules?

   as regards the LICENCE variable in the Makefile, I was unable to think
of a suitable one..  the code itself is free for all to use as far as I'm
concerned but the algorithm is patent encumbered so I thought there should
be some kind of restriction..

   This is a patch against ppp-2.4.0 as included in NetBSD, should I
really be providing a patch against latest ppp as included in pkgsrc?  In
fact I thought about this and downloaded ppp-2.4.2 but its not designed
to compile on anything but Linux or Solaris anyway, and I need the kernel
source to make the lkm anyway

iain


-------------------------------------------------------
This SF.Net email is sponsored by Sleepycat Software
Learn developer strategies Cisco, Motorola, Ericsson & Lucent use to deliver
higher performing products faster, at low TCO.
http://www.sleepycat.com/telcomwpreg.php?From=osdnemail3