|
|
Subject: Re: [PATCH] Print out the name of the anon region if possible - msg#00107
List: linux.oprofile
On Sat, Dec 16, 2006 at 11:04:12AM +0530, Amitabha Roy wrote:
> + name[0]=0;
name[0] = '\0';
> - snprintf(name, 1024, "%u.0x%llx.0x%llx", (unsigned int)anon->tgid,
> - anon->start, anon->end);
> +
> + snprintf(name, 1024, " %s %u.0x%llx.0x%llx", anon->name,
> + (unsigned int)anon->tgid, anon->start, anon->end);
No spaces in the file names please. Where have you changed the
demangling code to understand the new format?
regards
john
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
Was this page helpful?
Thread at a glance:
Previous Message by Date:
click to view message preview
Re: [PATCH] Print out the name of the anon region if possible
On Sat, Dec 16, 2006 at 11:04:12AM +0530, Amitabha Roy wrote:
> static void
> -add_anon_mapping(struct transient * trans, vma_t start, vma_t end)
> +add_anon_mapping(struct transient * trans, vma_t start, vma_t end, char *
> name)
Your mailer mangled the patch
john
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
Next Message by Date:
click to view message preview
Re: [PATCH] Print out the name of the anon region if possible
gmail mangles patches ? :(
Ok I will use an attachment next time. Sorry.
It outputs stuff like (no spaces now):
1 50.0000 sshd
1 50.0000 anon (tgid:[vdso] 4117 range:0xb7f8c000-0xb7f8d000)
and with -l
1 0.2551 anon (tgid:[vdso] 4117 range:0xb7f8c000-0xb7f8d000)
sshd (no symbols)
Also I couldnt find any code flow that would demangle this. Can you
point me to a file/function that you want me to fix? Or perhaps a use
case that would exercise the code you have in mind ?
Thanks
-Amitabha
On 12/21/06, John Levon <levon@xxxxxxxxxxxxxxxxx> wrote:
> On Sat, Dec 16, 2006 at 11:04:12AM +0530, Amitabha Roy wrote:
>
> > + name[0]=0;
>
> name[0] = '\0';
>
> > - snprintf(name, 1024, "%u.0x%llx.0x%llx", (unsigned int)anon->tgid,
> > - anon->start, anon->end);
> > +
> > + snprintf(name, 1024, " %s %u.0x%llx.0x%llx", anon->name,
> > + (unsigned int)anon->tgid, anon->start, anon->end);
>
> No spaces in the file names please. Where have you changed the
> demangling code to understand the new format?
>
> regards
> john
>
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
Previous Message by Thread:
click to view message preview
Re: [PATCH] Print out the name of the anon region if possible
On Sat, Dec 16, 2006 at 11:04:12AM +0530, Amitabha Roy wrote:
> static void
> -add_anon_mapping(struct transient * trans, vma_t start, vma_t end)
> +add_anon_mapping(struct transient * trans, vma_t start, vma_t end, char *
> name)
Your mailer mangled the patch
john
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
Next Message by Thread:
click to view message preview
Re: [PATCH] Print out the name of the anon region if possible
gmail mangles patches ? :(
Ok I will use an attachment next time. Sorry.
It outputs stuff like (no spaces now):
1 50.0000 sshd
1 50.0000 anon (tgid:[vdso] 4117 range:0xb7f8c000-0xb7f8d000)
and with -l
1 0.2551 anon (tgid:[vdso] 4117 range:0xb7f8c000-0xb7f8d000)
sshd (no symbols)
Also I couldnt find any code flow that would demangle this. Can you
point me to a file/function that you want me to fix? Or perhaps a use
case that would exercise the code you have in mind ?
Thanks
-Amitabha
On 12/21/06, John Levon <levon@xxxxxxxxxxxxxxxxx> wrote:
> On Sat, Dec 16, 2006 at 11:04:12AM +0530, Amitabha Roy wrote:
>
> > + name[0]=0;
>
> name[0] = '\0';
>
> > - snprintf(name, 1024, "%u.0x%llx.0x%llx", (unsigned int)anon->tgid,
> > - anon->start, anon->end);
> > +
> > + snprintf(name, 1024, " %s %u.0x%llx.0x%llx", anon->name,
> > + (unsigned int)anon->tgid, anon->start, anon->end);
>
> No spaces in the file names please. Where have you changed the
> demangling code to understand the new format?
>
> regards
> john
>
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
|
|