Re: External header guards (was: In the Works: New OOo C++ Coding Standards)

Hi Thosten,

On Tuesday 19 December 2006 21:40, Thorsten Behrens wrote:

> you wrote:
> > I hate them that much that I am willing to do a script that would do
> > the removal ;-)
> >
> > What is the platform/compiler that probably needs this, please?  Any
> > volunteer to do a comparison of the "with" and "without" compilation
> > times?
>
> That would be msvc 7.1
>
> Go ahead with the script (I'd take that anyway, once we switch to 8.0)
> - I can do the timings.

So - everything is ready ;-)

http://www.go-oo.org/ooo-build/bin/strip-guards

is the script to run over your sources (give it path to them as a parameter).

http://www.go-oo.org/ooo-build/patches/src680/strip-guards-additions.diff

is a patch to be applied over that (ooe680-m6), and finally

http://www.go-oo.org/ooo-build/patches/src680/fast-mkdepend.diff

is a fix for the mkdepend slowness with sources that do not have the external 
guards.  (BTW, makedepend is an unbelievable piece of software ;-)  It's 
optimized for everything - but for what it should be optimized for.  This 
patch should fix that, it cuts thousands [maybe millions?] of unnecessary 
descents through the structure to find that the symbol is really not defined 
[+ a better structure for holding the symbols].)

Please test - I'm eager to see the results with msvc ;-)

Merry Christmas, and a Happy New Year!

Thank you,
Jan