logo       

Re: In the Works: New OOo C++ Coding Standards: msg#00167

openoffice.devel.general

Subject: Re: In the Works: New OOo C++ Coding Standards

External header guards is not really the problem with makedepend. The
problem is that makedepend's running time is O(n^2) with n being the
number of source files in OOo. This is -after- the fixes, previously
it was more like O(n^3). Fixing this to run in O(n) means either
adding a new dependency type to dmake or using jam instead..

The external include guards are barely some smaller constant factor
for the O(n^2), if even that .. So IMHO we can happily ignore
makedepend in terms of deciding to strip out the external guards ..
:-)

Kai

On 12/20/06, Stephan Bergmann <stephan.bergmann@xxxxxxx> wrote:
If I remember correctly, I checked with a degenerate case with 100
headers where each header includes all the others, and one cxx that
includes all headers. I am not sure this scenario improves when calling
makedepend once for all cxx combined (of which there is only one in this
case, anyway) instead of once for each cxx individually.

--
Kai Backman, Software Engineer, kaib@xxxxxxxxxx


<Prev in Thread] Current Thread [Next in Thread>
Google Custom Search

News | FAQ | advertise