On Tue, 29 Jul 2003 17:33:03 -0700 (PDT)
Krishna Kumar <krkumar@xxxxxxxxxx> wrote:
> Since use_tempaddr can be -1, I am for the time being keeping all
> the variables as s32. If this is changed to __u32, then some code in
> addrconf.c needs to be modified.
Ok, but then please use "__s32".
> > I think something more like route metrics, ie. an array is more appropriate
>
> I guess you mean only the user interface to use route type metrics, not
> modify the existing cnf implementation to use this concept (eg remove the
> structure and define cnf_metrics[] with code similar to RTAX_HOPLIMIT,
> etc). So this patch doesn't change the usage in kernel, except now the
> user interface returns the config params in an array format.
>
> This patch applies on top of the prefix list patch.
I like the array scheme, but please you must define macros
(like RTAX_*) that give meaning to the array[] indices.
|
