logo       

Re: [PATCH] af_pppox: create module infrastructure for protocol modules: msg#00217

Subject: Re: [PATCH] af_pppox: create module infrastructure for protocol modules
   From: Arnaldo Carvalho de Melo <acme@xxxxxxxxxxxxxxxx>
   Date: Tue, 29 Apr 2003 03:54:19 -0300

   Em Mon, Apr 28, 2003 at 10:27:28PM -0700, David S. Miller escreveu:
   > Although the idea is conceptually sound, you miss one crucial thing.
   > Such struct sock's reference _TWO_ modules, the "PPPOE" module
   > and the "PPPOX" module.
   
   But what is the problem? at pppox_sk_alloc time I bump the PPPOE
   module refcnt, making it safe, then it calls sk_alloc where it
   bumps the PPPOX module, making it safe as well, so I'm taking care
   of both PPPOE and PPPOX.

You're absolutely correct, I missed this.

I'll pull your changes, thanks.




<Prev in Thread] Current Thread [Next in Thread>