Feldman, Scott writes:
> > It's clean but I have some concerns...
>
> Thanks for the feedback. It's a twist on the previous driver where we
> disabled/enabled interrupts each time we went in/out of polling. Trying
> to avoid those extra PCI writes. My experience is that you have to
> really load up the interface to stay in polling mode (get up on step).
True. Making interrupt delay larger will collect more packets on RX-ring
and have the two PCI-writes to disable/enables irq to be shared by many
packets.
> Should be the same interrupt rate with or without NAPI.
When NAPI stays in polling there are no interrupts and no extra PCI-writes
so the high-load situation is optimized.
So I fear that interrupts are now added to the high-load situation and this
will impact top performance -- especially with many NIC's.
But lets see what comes out from testing.
Cheers.
--ro
|
