logo       

Re: [PATCH] tg3 intr masking update: msg#00136

Subject: Re: [PATCH] tg3 intr masking update
Additional note about this change,

The NAPI docs mention specific areas where races may occur, and coincedentally so do the tg3 docs. The tg3 docs suggest to me that in tg3_poll, after we unmask ints, we should
* flush the MMIO write
* check the status block for updates again
* tell tg3 to deliver to us an artificial interrupt just in case we raced [IMO preferred versus simply returning 'not-done' in tg3_poll retval]

But this is just a theory and not tested yet...





<Prev in Thread] Current Thread [Next in Thread>