logo       

Re: [PATCH] IPv6: Refine IPv6 Address Validation Timer: msg#00292

Subject: Re: [PATCH] IPv6: Refine IPv6 Address Validation Timer
Hello!

> So, is this reasonable?

Yes, I like this.

Let's only delete this:

> +     if (time_before(now + HZ/2, jiffies)) {
> +             ADBG((KERN_WARNING 
> +                   "addrconf_verify(): too slow; jiffies - now = %ld\n",
> +                   (long)jiffies - (long)now));
> +     }

I do not understand how this survived. If you worry about infinite
spinning in loop you could make this check real, f.e. breaking loop
when jiffies >= now+2. In this form it is just mud.

Alexey





<Prev in Thread] Current Thread [Next in Thread>