|
osdir.com mailing list archive |
|
Subject: Re: CVS: loki.66h.42h.de: ports - msg#00069List: os.miros.generalinfrastructure/stools/lib: plist.c Log message: replace break; with goto foo; Oops. I am already working on refactoring this code, and I have gotten rid of the goto myself. Wait a bit for my patch. Hint: I discovered the 'break' thing while making this code a helper function, thus moving it out of the 'case' loop. --Benny. -- "Nimms nicht so tragisch, MirOS sind 1.8 fragile Gigabytes" -- mira im IRC Thread at a glance:
Previous Message by Date: click to view message preview?,8;?,=C @=AVCxA$ 0-H-!! 9L8. 4k:qGO=C18 D#18:P5i?!0T55 >K7AAV<<?d ^^*>U@87N 8^@OJ@8=C8i Next Message by Date: click to view message previewRe: CVS: loki.66h.42h.de: portsBenny Siegert dixit: >> replace break; with goto foo; ^^^^^[1] ^^^^[2] > Hint: I discovered the 'break' thing while making this code a helper function, ^^^^^^^^^^^^[3] > thus moving it out of the 'case' loop. Yes, I just came from the toilet to reply and clarify this, that I've not understood [1] in 6 years but knew [2] well already 14 years ago, and that [3] it was you who discovered that. But I urge you to read the Linux Kernel Coding Style, which, except for one deviation, is equivalent to KNF where they overlap. There is no such thing as a 'goto taboo'. And 80c _is_ a requirement. (Own functions for code blocks might be better though.) //mirabile Previous Message by Thread: click to view message previewRe: CVS: loki.66h.42h.de: portsStephen Paskaluk dixit: >> * the new variable is ${_CC_IS_GCC} which contains >> either "no" or the GCC version if ${CC} is a gcc >For the time being just being able to check for 3.4 will work, but >I'll play around with it to see what it can and can't do. Thanks >again :) Have fun. For reference, it's _CC_IS_GCC= 3.2.3 here. //mirabile Next Message by Thread: click to view message previewRe: CVS: loki.66h.42h.de: portsBenny Siegert dixit: >> replace break; with goto foo; ^^^^^[1] ^^^^[2] > Hint: I discovered the 'break' thing while making this code a helper function, ^^^^^^^^^^^^[3] > thus moving it out of the 'case' loop. Yes, I just came from the toilet to reply and clarify this, that I've not understood [1] in 6 years but knew [2] well already 14 years ago, and that [3] it was you who discovered that. But I urge you to read the Linux Kernel Coding Style, which, except for one deviation, is equivalent to KNF where they overlap. There is no such thing as a 'goto taboo'. And 80c _is_ a requirement. (Own functions for code blocks might be better though.) //mirabile Loading Comments...
|
|
