SF.net SVN: squirrelmail: [12405] trunk/squirrelmail/src/options_order.php

Revision: 12405
          
http://squirrelmail.svn.sourceforge.net/squirrelmail/?rev=12405&view=rev
Author:   pdontthink
Date:     2007-05-17 22:14:48 -0700 (Thu, 17 May 2007)

Log Message:
-----------
Add comments reminding someone to make a fix here

Modified Paths:
--------------
    trunk/squirrelmail/src/options_order.php

Modified: trunk/squirrelmail/src/options_order.php
===================================================================
--- trunk/squirrelmail/src/options_order.php    2007-05-18 02:59:18 UTC (rev 
12404)
+++ trunk/squirrelmail/src/options_order.php    2007-05-18 05:14:48 UTC (rev 
12405)
@@ -142,6 +142,7 @@
     }
 }
 
+// FIXME: why are we using this?  $PHP_SELF is already a global var processed 
(and therefore trustworthy) by init.php
 sqgetGlobalVar('PHP_SELF', $PHP_SELF, SQ_SERVER);
 $x = isset($mailbox) && $mailbox ? '&mailbox='.urlencode($mailbox) : '';
 
@@ -150,6 +151,7 @@
 $oTemplate->assign('not_used', $opts);
 $oTemplate->assign('always_show', array(SQM_COL_SUBJ, SQM_COL_FLAGS));
 
+// FIXME: (related to the above) $PHP_SELF might already have a query 
string... don't assume otherwise here by adding the ? sign!!
 $oTemplate->assign('move_up', $PHP_SELF .'?method=move&positions=-1'. $x 
.'&num=');
 $oTemplate->assign('move_down', $PHP_SELF .'?method=move&positions=1'. $x 
.'&num=');
 $oTemplate->assign('remove', $PHP_SELF .'?method=remove'. $x .'&num=');


This was sent by the SourceForge.net collaborative development platform, the 
world's largest Open Source development site.

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/