logo       
Google Custom Search
    AddThis Social Bookmark Button
-->

Re: SF.net SVN: squirrelmail: [12204] trunk/squirrelmail/plugins/squirrelsp: msg#00249

Subject: Re: SF.net SVN: squirrelmail: [12204] trunk/squirrelmail/plugins/squirrelspell
OMG, look at all that HTML in the core.... eeeeaaaaaghhh!  :-(  I know
it's not your fault, Thijs, it's just one more place that has to be
fixed....


On 1/26/07, kink-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@xxxxxxxxxxxxxxxx 
<kink-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@xxxxxxxxxxxxxxxx> wrote:
> Revision: 12204
>           
> http://squirrelmail.svn.sourceforge.net/squirrelmail/?rev=12204&view=rev
> Author:   kink
> Date:     2007-01-26 05:58:41 -0800 (Fri, 26 Jan 2007)
>
> Log Message:
> -----------
> add labels to make checkboxes better clickable
>
> Modified Paths:
> --------------
>     trunk/squirrelmail/plugins/squirrelspell/modules/edit_dic.mod
>     trunk/squirrelmail/plugins/squirrelspell/modules/enc_setup.mod
>     trunk/squirrelmail/plugins/squirrelspell/modules/lang_setup.mod
>     trunk/squirrelmail/plugins/squirrelspell/sqspell_functions.php
>
> Modified: trunk/squirrelmail/plugins/squirrelspell/modules/edit_dic.mod
> ===================================================================
> --- trunk/squirrelmail/plugins/squirrelspell/modules/edit_dic.mod       
> 2007-01-25 07:27:37 UTC (rev 12203)
> +++ trunk/squirrelmail/plugins/squirrelspell/modules/edit_dic.mod       
> 2007-01-26 13:58:41 UTC (rev 12204)
> @@ -61,8 +61,9 @@
>          $msg .= "</td><td valign=\"top\">\n";
>        }
>        $msg .= "<input type=\"checkbox\" name=\"words_ary[]\" "
> -        . 'value="'.htmlspecialchars($lang_words[$j]). '" /> '
> -        . htmlspecialchars($lang_words[$j]) . "<br />\n";
> +        . 'value="'.htmlspecialchars($lang_words[$j]). '" id="words_ary_'
> +        . $j . '" /> <label for="words_ary_' . $j .'">'
> +        . htmlspecialchars($lang_words[$j]) . "</label><br />\n";
>      }
>      $msg .= '</td></tr></table></td></tr>'
>        . "<tr bgcolor=\"$color[0]\" align=\"center\"><td>"
>
> Modified: trunk/squirrelmail/plugins/squirrelspell/modules/enc_setup.mod
> ===================================================================
> --- trunk/squirrelmail/plugins/squirrelspell/modules/enc_setup.mod      
> 2007-01-25 07:27:37 UTC (rev 12203)
> +++ trunk/squirrelmail/plugins/squirrelspell/modules/enc_setup.mod      
> 2007-01-26 13:58:41 UTC (rev 12204)
> @@ -61,9 +61,9 @@
>          . '<form method="post" onsubmit="return checkMe()">'
>          . '<input type="hidden" name="MOD" value="crypto" />'
>          . '<p align="center"><input type="checkbox" name="action" '
> -        . 'value="decrypt" /> '
> +        . 'value="decrypt" id="action_decrypt" /> <label 
> for="action_decrypt">'
>          . _("Please decrypt my personal dictionary and store it in a 
> clear-text format." )
> -        . '</p>'
> +        . '</label></p>'
>          . '<p align="center"><input type="submit" value=" '
>          . _("Change crypto settings")
>          . ' " /></p>'
> @@ -86,9 +86,9 @@
>          . '<form method="post" onsubmit="return checkMe()">'
>          . '<input type="hidden" name="MOD" value="crypto" />'
>          . '<p align="center"><input type="checkbox" name="action" '
> -        . 'value="encrypt" /> '
> +        . 'value="encrypt" id="action_encrypt" /> <label 
> for="action_encrypt">'
>          . _("Please encrypt my personal dictionary and store it in an 
> encrypted format.")
> -        . '</p>'
> +        . '</label></p>'
>          . '<p align="center"><input type="submit" value=" '
>          . _("Change crypto settings") . ' " /></p>'
>          . '</form>';
>
> Modified: trunk/squirrelmail/plugins/squirrelspell/modules/lang_setup.mod
> ===================================================================
> --- trunk/squirrelmail/plugins/squirrelspell/modules/lang_setup.mod     
> 2007-01-25 07:27:37 UTC (rev 12203)
> +++ trunk/squirrelmail/plugins/squirrelspell/modules/lang_setup.mod     
> 2007-01-26 13:58:41 UTC (rev 12204)
> @@ -28,16 +28,17 @@
>   * Present a nice listing.
>   */
>  $langs = sqspell_getSettings();
> -$add = '<p>'
> +$add = '<p><label for="lang_default">'
>    . _("Make this dictionary my default selection:")
> -  . " <select name=\"lang_default\">\n";
> +  . "</label> <select name=\"lang_default\" id=\"lang_default\">\n";
>  while (list($avail_lang, $junk) = each($SQSPELL_APP)){
>    $msg .= "<input type=\"checkbox\" name=\"use_langs[]\" "
> -    . "value=\"$avail_lang\"";
> +    . "value=\"$avail_lang\" id=\"use_langs_$avail_lang\"";
>    if (in_array($avail_lang, $langs)) {
>      $msg .= ' checked="checked"';
>    }
> -  $msg .= ' /> ' . _($avail_lang) . "<br />\n";
> +  $msg .= ' /> <label for="use_langs_' . $avail_lang . '">'
> +    . _($avail_lang) . "</label><br />\n";
>    $add .= "<option";
>    if ($avail_lang==$langs[0]) {
>      $add .= ' selected="selected"';
>
> Modified: trunk/squirrelmail/plugins/squirrelspell/sqspell_functions.php
> ===================================================================
> --- trunk/squirrelmail/plugins/squirrelspell/sqspell_functions.php      
> 2007-01-25 07:27:37 UTC (rev 12203)
> +++ trunk/squirrelmail/plugins/squirrelspell/sqspell_functions.php      
> 2007-01-26 13:58:41 UTC (rev 12204)
> @@ -864,10 +864,12 @@
>         '<input type="hidden" name="dict_lang" 
> value="'.htmlspecialchars($lang).'" />' :
>         '<input type="hidden" name="old_setup" value="yes" />')
>      . html_tag( 'p',  "\n" .
> -        '<input type="checkbox" name="delete_words" value="ON" />'
> -        . _("Delete my dictionary and start a new one") . '<br />'
> +        '<input type="checkbox" name="delete_words" value="ON" 
> id="delete_words" />'
> +        . '<label for="delete_words">'
> +        . _("Delete my dictionary and start a new one")
> +        . '</label><br /><label for="old_key">'
>          . _("Decrypt my dictionary with my old password:")
> -        . '<input name="old_key" size="10" />' ,
> +        . '</label><input type="text" name="old_key" id="old_key" size="10" 
> />' ,
>          'left' ) . "\n"
>          . '</blockquote>' . "\n"
>          . html_tag( 'p', "\n"
>
>
> This was sent by the SourceForge.net collaborative development platform, the 
> world's largest Open Source development site.
>
> -------------------------------------------------------------------------
> Take Surveys. Earn Cash. Influence the Future of IT
> Join SourceForge.net's Techsay panel and you'll get the chance to share your
> opinions on IT & business topics through brief surveys - and earn cash
> http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
> --
> squirrelmail-cvs mailing list
> List Address: 
> squirrelmail-cvs-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@xxxxxxxxxxxxxxxx
> List Info: https://lists.sourceforge.net/lists/listinfo/squirrelmail-cvs
> http://squirrelmail.org/cvs
>

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV


<Prev in Thread] Current Thread [Next in Thread>