Re: [RFC][PATCH] Xilinx uartlite serial driver

Peter Korsgaard wrote:
> > > > > > "David" == David H Lynch <dhlii@xxxxxxxxxx> writes:
> > > > > >             
>
> Hi,
>
>  David>      You need an "early_serial_setup()" routine inside the
>  David> CONFIG_SERIAL_UARTLITE_CONSOLE code.
>
> Isn't that just for early serial support?
>
>   
   Honestly,  I can not tell. It is implimented in 8250.c, and I think 
some other drivers. I think it was  related to early_serial. But I think 
that is now moved into the main driver, not a separate early_serial driver.
   I stubbed it out to nothing just to make the linker happy and 
noticed no obvious difference in behavior. But due to printk buffering, 
it might be very hard to see a difference - unless there was an early 
failure.

   What I know is that:
                the ml403 8250 support (as well as many other drivers), 
impliment it
                that they pass a uart_port structure
                and that it may be called for each port,
              
   I beleive that it may be more important than the uartlite_tty.c and 
uartlite_dbg.c that get used very breifly by much earlier code.
   But I am just guessing.
  
   I know that my driver impliments it and as a result I usually see 
messages up to the moment of failure when there is a failure, and do not 
get into a bind because they are stuck in a printk buffer.










--
Dave Lynch                                                  DLA Systems
Software Development:                                    Embedded Linux
717.627.3770           dhlii@xxxxxxxxxx           http://www.dlasys.net
fax: 1.253.369.9244                                Cell: 1.717.587.7774
Over 25 years' experience in platforms, languages, and technologies too 
numerous to list.

"Any intelligent fool can make things bigger and more complex... It takes a touch of 
genius - and a lot of courage to move in the opposite direction."
Albert Einstein

-
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html