Re: [RFC][PATCH] Xilinx uartlite serial driver

>>>>> "David" == David H Lynch <dhlii@xxxxxxxxxx> writes:

Sorry for the delay, I've been ill..

 David>    There is more than one UartLite driver. I have one from someone
 David> else that includes DCR support.
 David>    I wrote one that includes early boot console support - which is
 David> fairly trivial.

Yes, I know (after writing mine). That's why getting the driver
mainline is important, otherwise people will keep on reinventing the
wheel..

 David>    I will try to separate out my early boot console patches - would
 David> this be the appropriate place to post them ?

Yes, presumably once the base driver goes in.

 David>   I beleive my driver is the one Peter  believes is broken.

Me? I don't even think I ever tried your driver..

 David>       I can't quite understand why one would build a Xilinx FPGA with 
both.

We have done it several times. 16550s for when you need full
functionality (changeable baudrate, control lines, ..) and uartlites
for dedicated links.

 David>    If Peter's driver is likely to get accepted I have all of the
 David> platform device code done for my own driver I can move it to his.
 David>    I did a BSP for the Pico E12/E14, they use either UartLite out of
 David> the box, or a pseudo serial device they call the Keyhole
 David>    that can be used if the E12/E14 are hosted (they are CF/Cardbus
 David> cards respectively)

Ok, but where would you add it? The ML300/403 boards are afaik the
only ones in mainline.

-- 
Bye, Peter Korsgaard
-
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html