https://bugzilla.livna.org/show_bug.cgi?id=848
------- Additional Comments From bugs.michael@xxxxxxx 2007-04-15 02:06 -------
Packaging-wise, a first brief look:
$ rpmlint ices0-0.4.svn12258-16.src.rpm
E: ices0 description-line-too-long multiple simultaneous different streams
(proccesses) of ices0, resembling the way
W: ices0 strange-permission ices0.logrotate 0666
W: ices0 mixed-use-of-spaces-and-tabs (spaces: line 71, tab: line 21)
* Package version does not adhere to Fedora package versioning guidelines.
Should be changed to: ices0-0.4-16.svn12258
Which means: Keep the %version clean, keep the package %release number
most-significant, and don't include svn/cvs-post/pre-release details in
%version.
* Source0 URL points to an official release. Included tarball is a self-made svn
checkout. In that case, it is common practise to give the tarball a proper file
name and don't include a wrong download URL, e.g.:
Source0: ices-0.4.svn12258.tar.gz
#Source0: http://downloads.us.xiph.org/releases/ices/ices-0.4.tar.gz
* Spelling mistakes in %description and added README: pattent -> patent,
procceses -> processes
* Use either %{buildroot} or ${RPM_BUILD_ROOT}, but not both.
* /usr/share/man -> ${_mandir}
* ices0 service must not be enabled by default
Test-build (FC6):
> '--with-python-includes=/usr/include/python%{py_ver}'
Undefined RPM macro!
> checking for python... /usr/bin/python
> checking Python.h usability... no
> checking Python.h presence... no
> checking for Python.h... no
> configure: WARNING: Python.h doesn't appear to be usable
> Could not link to python, python scripting disabled
Perhaps missing BuildRequires: python-devel
Else this feature ought to be disabled.
> checking FLAC/stream_decoder.h usability... no
> checking FLAC/stream_decoder.h presence... no
> checking for FLAC/stream_decoder.h... no
> configure: error: Could not find libFLAC
Missing BuildRequires: flac-devel
> Features:
> MP4 : no
Why no libfaad support?
$ rpmlint ices0-0.4.svn12258-16.i386.rpm
W: ices0 incoherent-version-in-changelog 0.4.svn12258 0.4.svn12258-16
E: ices0 executable-marked-as-config-file /etc/rc.d/init.d/ices0
W: ices0 file-not-utf8 /usr/share/man/man1/ices0.1.gz
E: ices0 non-executable-script /etc/ices0/dynamic-playlist.sh 0644
W: ices0 service-default-enabled /etc/rc.d/init.d/ices0
Init-script needs work. Default server starts, fails, but error return code is
not recognised:
# service ices0 start
Starting ices0 streams:
default [ OK ]
$ sudo service ices0 status
ices0 dead but subsys locked
$ sudo service ices0 condrestart
/etc/init.d/ices0: line 93: restart: command not found
$ man ices0
XXX
XXX WARNING: old character encoding and/or character set
XXX
-snip-
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
|
