logo       

Re: xeno-test manpage patch: msg#00225

linux.real-time.xenomai.devel

Subject: Re: xeno-test manpage patch

Hi,

Here is a patch for the manpages.


Jim Cromie wrote:
> Romain Lenglet wrote:
> > Added documentation for the new -U option, and did some
> > cleanups.
>
> FYI,
>
> a few *tiny* issues.
>
> -d eg: /dev/hda1 might be better than /dev/hda/, and drop
> trailing slash.
>
> -m, -M. log-file not required.
>
> -N path can be /absolute too, not just ../relative
>
> -p 'cmd' no longer run between latencies, just before &
> after
>
> pass-thru:
>
> -s -T 10 -q the 10 is now 120.

Done.

> more subtly - your intro doesnt express the defaulting
> behavior that this section does describe.
> any pass-thru provided with turn off those defaults, so if you
> just use -h, the test will output lines
> each second, and never finish, so you dont get histogram (IIRC
> - you may get it from ^C handler).
> Im not at all sure its worth touching, and I should probably
> change the defaults to add histogram,
> and drop quiet.

Added warning line:
"Any user-specified set of options overrides this default set of
options."

> -h implies -s (its just easier that way)

Done.

> -- needed by testsuite/*/run scripts, not by xeno-test. I
> dont recall every using it.

xeno-test uses getopts to parse options, and getopts parses -- to
identify the end of options, e.g. if you run:
xeno-test -s -- -v
-v is not recognized as an option.

> BUGS
>
> -N name is timestamped, giving uniqueness. This is a
> caveat, not a bug

No, it is a feature. I added it into the documentation of -L
and -N.
By the way, I suggest that you use a timestamp in the RFC 3339
format (a subset of ISO 8601):
date "+%Y-%m-%d %H:%M:%S%:z"
or, assuming date is GNU date:
date --rfc-3339=seconds

> -p oops. Im open to suggestions whether this is worth
> fixing.
>
> (workload mgmt)
>
> workload tasks arent always (ever?) restarted once they
> finish, so a real /dev/hda1 workload may end before your test
> does, causing non-uniform &
> unexpected load variations.
>
> workloads arent always killed if test is interrupted.

Added into the bugs section.



Now, it is my turn to make some remarks on xeno-test... ;)

1-
Option "-u" is in the list of options given to getopts: you
should remove it for now.

2-
I don't know why there is a sort of option "-n" in the case:
n)
# accept note (from the outer process)
notes=$OPTARG ;;
Those three lines should be removed: this is dead code.

--
Romain LENGLET

Attachment: xeno-test-doc_2006-04-29.patch
Description: Text Data

_______________________________________________
Xenomai-core mailing list
Xenomai-core@xxxxxxx
https://mail.gna.org/listinfo/xenomai-core
<Prev in Thread] Current Thread [Next in Thread>
Google Custom Search

News | FAQ | advertise