multipath bug in 2.5

Hi,

I've just casually glanced over 2.5 code to see how much work it would be to
port forward, and I think I noticed a bug in multipath_add_disk:

        for (path=0; path<mddev->raid_disks; path++)
                if ((p=conf->multipaths+path)->rdev == NULL) {
                        p->rdev = rdev;
                        conf->working_disks++;
                        rdev->raid_disk = path;
                        rdev->in_sync = 1;
                        found = 1;
                }

Is it just me or will that fill in every empty path? Might make sense to add
a break in there.

But otherwise, wow, the code is looking so much nicer, finally no longer all
thos replicated datastructures, bit fields, ordered lists etc to keep in
sync... This is going to be a big step forward.


Sincerely,
    Lars Marowsky-Brée <lmb@xxxxxxx>

-- 
SuSE Labs - Research & Development, SuSE Linux AG
  
"If anything can go wrong, it will." "Chance favors the prepared (mind)."
  -- Capt. Edward A. Murphy            -- Louis Pasteur
-
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html