Re: [PATCH] md - 1 of 12 - Missing mddev_put in md resync code

On  March 13, skormilo@xxxxxxxxxxxxxxxxxx wrote:
> > Would this be when removing a recently-failed device?  That can still
> > oops.  I should send in a patch for that...
> 
> Yes in fact, that is the one I was seeing.
> 

That one *should* be fixed in 2.4.-current-bk, but probably not
completely.  It is actually rather hard to get it just-right in 2.4.
I substantially reworked the 2.5 code so that proper locking could be
done so that this sort of problem could be avoided.  
2.4 will porbably have to stay with "close-enough".

> 
> I have an odd problem where the first rebuild performs as expected
> (about 40MB/s), but any subsequent rebuild plods along at about 6-7MB/s.
> There is no IO activity on the system other than the rebuild during my
> tests.

Does upping /proc/sys/dev/raid/speed_limit_min affect the speed?

Does increasing the magic "32" in is_mddev_idle help?

> 
> I tried putting in a couple of debug printk's here and there in the code
> that backs off the resync, and the printk's themselves returned the
> performance back to expected levels... some kind of a timing problem
> perhaps?

Don't you  hate that!

NeilBrown
-
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html