Re: [discuss] Re: x86_64: 2.6.14-rc4 swiotlb broken

Thanks a lot for your explanation!

> On Wed, Oct 19, 2005 at 01:45:21PM -0700, Linus Torvalds wrote:
> > ... 
> > Can you re-post the final version as such, with explanations for the 
> > commit messages and the sign-off, and people who have issues with it 
> > _please_ speak up asap?
> 
> The final version which works for everyone is from Yasunori Goto. 
> 
> His patch introduces a limit parameter to the core bootmem allocator;  This
> new parameter indicates that physical memory allocated by the bootmem 
> allocator
> should be within the requested limit.  The patch also introduces
> alloc_bootmem_low_pages_limit(), alloc_bootmem_node_limit,
> alloc_bootmem_low_pages_node_limit apis, but alloc_bootmem_low_pages_limit()
> is the only api used for swiotlb.  IMO, instead of introducing xxx_limit apis,
> the existing alloc_bootmem_low_pages() api could instead be changed and made 
> to pass right limit to the core allocator.  But then that would make the 
> patch more intrusive for 2.6.14, as other  arches use 
> alloc_bootmem_low_pages().

Yes. I worried a bit that I should replace all of the function or not.
But, its impact is too risky for 2.6.14. So, I wrote the patch to avoid
big impact as much as possible.

> (So maybe that can be done post 2.6.14 if Yasunori-san is OK with that)

Sure! 

-- 
Yasunori Goto