Re: x86_64: 2.6.14-rc4 swiotlb broken

On Mon, 17 Oct 2005, Andrew Morton wrote:
> 
> There seem to be a lot of proposed solutions floating about and I fear that
> different people will try to fix this in different ways.  Do we all agree
> that this patch is the correct solution to this problem, or is something
> more needed?

I think this will fix it. 

The naming is horrible, though, and that whole "goal" parameter is 
senseless and ugly.

It should just be a flag on whether we want DMA'able memory or not. That's 
what it _is_, it's just strangely implemented, making the code less 
readable.

Since the patch changes all the users of that third parameter _anyway_, it 
should probably be fixed to just make the parameter sane instead.

                Linus