Re: [linux-sh:03163] Re: [PATCH] Optimise io_generic outsw/outsl routines

On Sat, 2004-02-21 at 15:18, Paul Mundt wrote:
> On Thu, Feb 19, 2004 at 03:29:10PM +0000, Alex Bennee wrote:
> > FWIW the old patch was incomplete. A more complete patch is attached if
> > you want to apply it to HEAD (I made it from 2.4 but I assume its not
> > changed to much).
> > 
> I needed to change it around a bit, since I was getting things like:
> 
>   CC      arch/sh/kernel/io_generic.o
> arch/sh/kernel/io_generic.c: In function `generic_outsw':
> arch/sh/kernel/io_generic.c:172: warning: assignment makes pointer from 
> integer without a cast
> arch/sh/kernel/io_generic.c:175: warning: assignment of read-only location
> arch/sh/kernel/io_generic.c: In function `generic_outsl':
> arch/sh/kernel/io_generic.c:185: warning: assignment makes pointer from 
> integer without a cast
> arch/sh/kernel/io_generic.c:188: warning: assignment of read-only location
>   LD      arch/sh/kernel/built-in.o
> make[1]: *** [arch/sh/kernel/built-in.o] Interrupt
> make: *** [arch/sh/kernel] Interrupt

Of course if you want to do the casting right ;-) I hadn't seen the
read-only warning but the changes are clean.

> amongst others. This is what I have now, which builds and boots.
> (Against HEAD, obviously). You'll probably want the same thing for your
> 2.4 tree, especially if you ever use a more up to date compiler.

I'm currently on still on 2.4.22 (I know there are needed fixes - just
not right now!) so I've got the io_generic in my own tree. I can check
them into the head of 2.4 in the next few days if no one else complains.

-- 
Alex, homepage: http://www.bennee.com/~alex/
This is a test of the emergency broadcast system.  Had there been an
actual emergency, then you would no longer be here.



-------------------------------------------------------
SF.Net is sponsored by: Speed Start Your Linux Apps Now.
Build and deploy apps & Web services for Linux with
a free DVD software kit from IBM. Click Now!
http://ads.osdn.com/?ad_id=1356&alloc_id=3438&op=click