Re: [PATCH]: linux-2.6 x86_64 kgdb issue

On Fri, May 19, 2006 at 10:15:39PM +0400, Vladimir A. Barinov wrote:

> The stack exception occurs always at the same step during debugging in 
> kgdb_mem2hex().
> I've attached patch that fixes this issue.  Could you please review, is 
> this patch appropriate
> to the problem?
> 
> Vladimir

> --- kgdb.c.orig       2006-05-19 19:41:22.000000000 +0400
> +++ /home/volodia/work/Irwindale/linux-2.6.16/arch/x86_64/kernel/kgdb.c       
> 2006-05-19 21:26:14.000000000 +0400
> @@ -421,8 +421,8 @@ static int kgdb_notify(struct notifier_b
>       struct die_args *args = ptr;
>       struct pt_regs *regs = args->regs;
>  
> -     if (cmd == DIE_PAGE_FAULT_NO_CONTEXT && atomic_read(&debugger_active)
> -                     && kgdb_may_fault) {
> +     if ((cmd == DIE_PAGE_FAULT_NO_CONTEXT || cmd == DIE_TRAP) 
> +                     && atomic_read(&debugger_active) && kgdb_may_fault) {
>               kgdb_fault_longjmp(kgdb_fault_jmp_regs);
>               return NOTIFY_STOP;
>       /* CPU roundup? */

I believe this to be OK, but I need to think about it a bit more.
Thanks!

-- 
Tom Rini


-------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642