Re: Separate 'continue' and 'step' handling from other remote packet handling

On 1/31/06, Tom Rini <trini@xxxxxxxxxxxxxxxxxxx> wrote:
> On Wed, Jan 25, 2006 at 01:30:44PM -0800, Jim Blandy wrote:
>
> > On 1/25/06, Tom Rini <trini@xxxxxxxxxxxxxxxxxxx> wrote:
> > > On Tue, Jan 24, 2006 at 10:30:13PM -0800, Jim Blandy wrote:
> > >
> > > > Index: linux-2.6.11/include/linux/kgdb.h
> > >
> > > Any chance you can speak unified diff? Please?  Thanks!
> >
> > I have difficulties reading unified diffs, because they mix the
> > context with both old and new text.  If there are interesting control
> > flow changes, I get lost.
>
> I have the same problem in the other direction so thanks!

No prob.  I take it unidiff is the consensus, so I'll convert before posting.

> > --- linux-2.6.11.orig/kernel/kgdb.c
> > +++ linux-2.6.11/kernel/kgdb.c
> > @@ -288,6 +288,12 @@ struct pt_regs __attribute__ ((weak))
> >       return NULL;
> >  }
> >
> > +extern int __attribute__ ((weak))
> > +    kgdb_single_step (struct pt_regs *regs, int at_addr, unsigned long 
> > addr)
> > +{
> > +        return -EINVAL;
> > +}
>
> No extern here.

D'oh.

> [snip]
> > Index: linux-2.6.11/arch/i386/kernel/kgdb.c
> > ===================================================================
> > --- linux-2.6.11.orig/arch/i386/kernel/kgdb.c
> > +++ linux-2.6.11/arch/i386/kernel/kgdb.c
> > @@ -255,53 +255,66 @@ int kgdb_arch_handle_exception(int e_vec
> >                              char *remcom_out_buffer,
> >                              struct pt_regs *linux_regs)
> >  {
>
> We should probably turn kgdb_arch_handle_exception into an optional function
> now and make the default weak version just return -1 since _most_ arches
> don't have other packets to handle.

Yes, that sounds right.

I don't have the actual tracepoints themselves going yet, so I don't
want to get bogged down in preliminaries at this point, but I will get
back to revising this patch, re-establishing it against the current
KGDB sources, and re-posting.

Thanks for the review!


-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid3432&bid#0486&dat1642