Re: kgdb on arm for 2.6

On Tue, Jan 10, 2006 at 09:22:23AM -0800, George Anzinger wrote:
> Amit Kale wrote:
> >Lance,
> >
> >The TASK_SIZE check in kgdb prevents reading user memory when kgdb holds a 
> >kernel. User memory could be swapped out in case of MMU systems, so doing 
> >it from inside kgdb might cause a lockup if the page being refered to has 
> >to be brought in.
> 
> If I recall correctly, this was a check to avoid the memory fault such an 
> access would create.  Since we now correctly detect and recover from these 
> after the fact, I think this code should be removed.  Am I remembering 
> wrong here?

I think at worst the additional check is an optimization, it's much
quicker to test that than to actually hit the fault and recover.  But
it's possible we need that check there for other reasons (I don't have
time to test all of the corner cases right now 'tho).

-- 
Tom Rini
http://gate.crashing.org/~trini/


-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click