Download Firefox: WindowsMac OS X
logo       
Google Custom Search
    AddThis Social Bookmark Button

Re: [PATCH 16/21] orinoco_pci: disable device and free IRQ when suspending: msg#00026

Subject: Re: [PATCH 16/21] orinoco_pci: disable device and free IRQ when suspending
Pavel Roskin <proski-mXXj517/zsQ@xxxxxxxxxxxxxxxx> :
[...]
> diff --git a/drivers/net/wireless/orinoco_pci.c 
> b/drivers/net/wireless/orinoco_pci.c
> index 5362c21..e57e92b 100644
> --- a/drivers/net/wireless/orinoco_pci.c
> +++ b/drivers/net/wireless/orinoco_pci.c
> @@ -304,7 +304,9 @@ static int orinoco_pci_suspend(struct pc
>       
>       orinoco_unlock(priv, &flags);
>  
> +     free_irq(pdev->irq, dev);
>       pci_save_state(pdev);
> +     pci_disable_device(pdev);
>       pci_set_power_state(pdev, PCI_D3hot);
>  
>       return 0;

/me stares at the thread behind http://lkml.org/lkml/2005/7/30/143

Imho {free/request}_irq during suspend/resume deserves some
explanation.

-- 
Ueimor


-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642


<Prev in Thread] Current Thread [Next in Thread>