Hello!
On Mon, 2005-07-04 at 19:02 +0200, abuas_z wrote:
> Hello,
>
> In attachement you have got corrected by me orinoco_usb.c file.
Please send patches rather than whole files unless you are making a
complete rewrite. I see some changes that you didn't describe, such as
whitespace changes that actually make the code less readable. Maybe
your mail software mangled some tabs?
It would be great if you leave formatting changes to maintainers or send
them as a separate patch. I cannot apply your patches without
reviewing, and whitespace changes make reviewing harder.
What's wrong with multi-line comments? Why are you trying to unwrap
them even if they become too long?
> Correction were adding few orinoco-known-to-work cards. These
> devices are known to work, because they are handle by the same
> Windows driver as orinoco-usb (Windows INF file contains all this
> PID&VID linked to the same files with only different brand names):
>
> Wireless USB Card Model 0802 (Vid_0D4E&Pid_1001)
> BUFFALO WLI-USB-L11 Wireless LAN Adapter (Vid_0411&Pid_0006)
> BUFFALO WLI-USB-L11G Wireless LAN Adapter (Vid_0411&Pid_000D)
> Samsung SEW-2003U Card (Vid_04E8&Pid_7011)
That's a good idea. I'll add them. But first we'll need to fix a
little problem. We having three ID tables instead of one. It's too
fragile. We should use driver_info field of struct usb_device_id to
mark devices as variant 1, variant 2 or unknown.
> Also I changed invalid entry:
>
> #define USB_FUJITSU_VENDOR_ID0x0BF
>
> to proper one:
>
> #define USB_FUJITSU_VENDOR_ID0x0BF8
You missed tab here. I have fixed and applied this part.
> and I corrected some letter-bugs, like SANSUNG - SAMSUNG, etc.
Also applied.
> You can safely replace with this file exsisting file from HEAD CVS
> branch.
I know that orinoco_usb.c has not been changed recently, but in general,
you should specify revision of the file if you really going to replace
it. That said, a patch is better because both you and the person
applying it can see what has been changed, and because a patch won't
ever revert changes made by others.
> The next thing to change will be correcting errors after plug-in to
> USB orinoco-usb (obsolete functions use, etc).
OK.
--
Regards,
Pavel Roskin
-------------------------------------------------------
SF.Net email is sponsored by: Discover Easy Linux Migration Strategies
from IBM. Find simple to follow Roadmaps, straightforward articles,
informative Webcasts and more! Get everything you need to get up to
speed, fast. http://ads.osdn.com/?ad_id=7477&alloc_id=16492&op=click
|
