Download Firefox: WindowsMac OS X
logo       
Google Custom Search
    AddThis Social Bookmark Button

[0/15] orinoco merge preliminaries: msg#00018

Subject: [0/15] orinoco merge preliminaries
On Tue, Jul 27, 2004 at 01:18:03PM -0400, Jeff Garzik wrote:
> >I've started to have a look at the patches.  Unfortunately, they're
> >still not really as logically separated as they should be.  Which I
> >guess means I wasn't sufficiently disciplined putting them into CVS in
> >the first place.
> >
> >I've started working on my own series of logical patches, starting
> >with, as you say the "content free" ones first.  Initial set with
> >series file at
> >       http://www.ozlabs.org/people/dgibson/orinoco-patches
> >
> >Nothing there so far that should cause any functional change.
> 
> 
> Feel free to start emailing them, so I can queue them up.
> 
> One email per patch, please.

Ok, patchbombing commences.

Following are 15 patches which make a start on merging the current CVS
orinoco driver into the mainline tree.  This batch of patches is only
preliminaries - patches which cause no behavioural change, but which
should be easy to review and which will reduce meaningless noise in
the later functional patches.

They all represent essentially trivial changes, and with the exception
of the rearrange patch (which is large because it moves big chunks of
code around) they should be obvious.  This batch of patches is
supposed to represent all the trivial, non-behaviour-changing
differences between orinoco CVS and mainline, though the merge is so
large, inevitably I will have missed a few.

Summary of the patches:
        1/15 orinoco-squash-backwards-compat:
                Removes old unnecessary backwards compatibility code
        2/15 orinoco-rearrange:
                Rearrange code so function order matches new versions
        3/15 orinoco-netdev-priv:
                Use netdev_priv() instead of direct dev->priv access
        4/15 orinoco-ALIGN:
                Use standard ALIGN macro instead of local versions
        5/15 orinoco-ARRAY-SIZE:
                Use ARRAY_SIZE macro instead of local version
        6/15 orinoco-spam-stoppers:
                Anti-spam obfuscate email addresses in source
        7/15 orinoco-comments-whitespace-spelling
                Whitespace/spelling/capitalisation updates
        8/15 orinoco-BUG-ON:
                Use BUG_ON() instead of explicit if () BUG() logic
        9/15 orinoco-add-statics:
                Make some functions static that always should have been
        10/15 orinoco-trivial-cleanup:
                Tiny changes than don't belong with anything else
        11/15 orinoco-driver-name-version:
                Reduce duplication of the driver names/version
        12/15 orinoco-uneeded-includes:
                Remove unnecessary #includes
        13/15 orinoco-no-struct-typedef:
                Don't use typedefs on simple structues
        14/15 orinoco-more-hw-data:
                Extra hw related #defines and structures
        15/15 orinoco-update-authorship:
                Update MAINTAINERS, copyright banners, etc.

-- 
David Gibson                    | For every complex problem there is a
david AT gibson.dropbear.id.au  | solution which is simple, neat and
                                | wrong.
http://www.ozlabs.org/people/dgibson


-------------------------------------------------------
This SF.Net email is sponsored by BEA Weblogic Workshop
FREE Java Enterprise J2EE developer tools!
Get your free copy of BEA WebLogic Workshop 8.1 today.
http://ads.osdn.com/?ad_id=4721&alloc_id=10040&op=click


<Prev in Thread] Current Thread [Next in Thread>