Bug#320350: marked as forwarded (asterisk: bristuff patch breaks cause codes in Hangup())

Your message dated Fri, 29 Jul 2005 07:35:40 +0100
with message-id <200507290735.40598.msp@xxxxxxxxxx>
has caused the Debian Bug report #320350,
regarding asterisk: bristuff patch breaks cause codes in Hangup()
to be marked as having been forwarded to the upstream software
author(s) kpj@xxxxxxxxxxxxxx

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

---------------------------------------
Received: (at 320350-forwarded) by bugs.debian.org; 29 Jul 2005 06:36:24 +0000
>From msp@xxxxxxxxxx Thu Jul 28 23:36:24 2005
Return-path: <msp@xxxxxxxxxx>
Received: from (dell.purcell.id.au) [212.139.8.15] 
        by spohr.debian.org with esmtp (Exim 3.36 1 (Debian))
        id 1DyOTn-0002Db-00; Thu, 28 Jul 2005 23:36:23 -0700
Received: from mark by dell.purcell.id.au with local (Exim 4.52)
        id 1DyOT6-0000U7-Mv; Fri, 29 Jul 2005 07:35:41 +0100
From: Mark Purcell <msp@xxxxxxxxxx>
Organization: Debian GNU Linux
To: kpj@xxxxxxxxxxxxx
Subject: Re: Bug#320350: asterisk: bristuff patch breaks cause codes in Hangup()
Date: Fri, 29 Jul 2005 07:35:40 +0100
User-Agent: KMail/1.8.1
References: <20050728173116.C39E512021808@xxxxxxxxxxxxxxxxxxxxx>
In-Reply-To: <20050728173116.C39E512021808@xxxxxxxxxxxxxxxxxxxxx>
Cc: 320350-forwarded@xxxxxxxxxxxxxxx,
 rain <rain@xxxxxxxxxxxxxx>
Disposition-Notification-To: Mark Purcell <msp@xxxxxxxxxx>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200507290735.40598.msp@xxxxxxxxxx>
Delivered-To: 320350-forwarded@xxxxxxxxxxxxxxx
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02 
        (1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Level: 
X-Spam-Status: No, hits=-6.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER 
        autolearn=no version=2.60-bugs.debian.org_2005_01_02

On Thursday 28 July 2005 18:31, rain wrote:
> I'm not entirely certain where to report this, because bristuff doesn't
> appear to be properly maintained anymore on its original site, and I'm
> not sure where development is currently happening.

Rain,

Thanks for the patch.

Bristuff has had three releases in July alone, so I think things are 
progressing. http://www.junghanns.net/asterisk/downloads/?C=M;O=D

Klaus-Peter. You might want to have a look at the attached patch. Btw, I am 
unaware if you realise that Debian GNU/Linux ships asterisk with your 
bristuff patches applied, as we release under the GPL as well.  We would be 
greatful for any other suggestions as to how we can maintain the two code 
bases merged.

Mark

>
> The bristuff patch changes pbx_builtin_hangup to accept a cause code
> as a parameter--however, the parameter is often passed to the function
> as "" instead of NULL, so the code in the patch:
>         /* Copy the hangup cause as specified */
>         if (data)
>            chan->hangupcause = atoi(data);
>
> will (almost?) always reset the cause code to 0.  This will result in
> the channel being hung up reporting a useless cause code (and, in the
> case of SIP phones, a very confusing "403 Forbidden".)
>
> Just changing the patch to be:
>       /* Copy the hangup cause if specified */
>       if (data && *data)
>          chan->hangupcause = atoi(data);
>
> will fix the problem.
>
> A temporary workaround (without recompiling) is to always call Hangup()
> with ${HANGUPCAUSE} as a parameter.
>
> -- System Information:
> Debian Release: testing/unstable
>   APT prefers unstable
>   APT policy: (500, 'unstable')
> Architecture: i386 (i686)
> Shell:  /bin/sh linked to /bin/dash
> Kernel: Linux 2.6.11-1-686
> Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
>
>
> _______________________________________________
> Pkg-voip-maintainers mailing list
> Pkg-voip-maintainers@xxxxxxxxxxxxxxxxxxxxxxx
> http://lists.alioth.debian.org/mailman/listinfo/pkg-voip-maintainers