Bug#319304: marked as done (FTBFS: conflicting declarations of uniquelock)

Your message dated Thu, 28 Jul 2005 23:17:04 -0700
with message-id <E1DyOB6-0006Fn-00@xxxxxxxxxxxxxxxx>
and subject line Bug#318337: fixed in asterisk 1:1.0.9.dfsg-4
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--------------------------------------
Received: (at submit) by bugs.debian.org; 21 Jul 2005 01:45:20 +0000
>From kraai@xxxxxxxx Wed Jul 20 18:45:20 2005
Return-path: <kraai@xxxxxxxx>
Received: from zoot.lafn.org [206.117.18.6] 
        by spohr.debian.org with esmtp (Exim 3.36 1 (Debian))
        id 1DvQ7k-0002dq-00; Wed, 20 Jul 2005 18:45:20 -0700
Received: from localhost.localdomain 
(pool-71-104-165-253.lsanca.dsl-w.verizon.net [71.104.165.253])
        (authenticated bits=0)
        by zoot.lafn.org (8.13.1/8.13.1) with ESMTP id j6L1jJxD065540
        (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NO)
        for <submit@xxxxxxxxxxxxxxx>; Wed, 20 Jul 2005 18:45:20 -0700 (PDT)
        (envelope-from kraai@xxxxxxxx)
Received: from kraai by localhost.localdomain with local (Exim 4.52)
        id 1DvGWT-0001AM-Iq
        for submit@xxxxxxxxxxxxxxx; Wed, 20 Jul 2005 08:30:13 -0700
Date: Wed, 20 Jul 2005 08:30:13 -0700
From: Matt Kraai <kraai@xxxxxxxxx>
To: submit@xxxxxxxxxxxxxxx
Subject: FTBFS: conflicting declarations of uniquelock
Message-ID: <20050720153012.GE4190@xxxxxxxxxxxxxxxxxxxxx>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
        protocol="application/pgp-signature"; boundary="vKFfOv5t3oGVpiF+"
Content-Disposition: inline
User-Agent: Mutt/1.5.9i
X-Virus-Scanned: ClamAV version 0.85.1, clamav-milter version 0.85 on 
zoot.lafn.org
X-Virus-Status: Clean
Delivered-To: submit@xxxxxxxxxxxxxxx
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02 
        (1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Level: 
X-Spam-Status: No, hits=-2.4 required=4.0 tests=BAYES_00,DATE_IN_PAST_06_12 
        autolearn=no version=2.60-bugs.debian.org_2005_01_02


--vKFfOv5t3oGVpiF+
Content-Type: multipart/mixed; boundary="LSp5EJdfMPwZcMS1"
Content-Disposition: inline


--LSp5EJdfMPwZcMS1
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Package: asterisk
Version: 1.0.9.dfsg-3
Severity: serious
Tags: patch

asterisk fails to build because it declares uniquelock as extern in
channel.h and defines is as static in channel.c:

gcc -pipe  -Wall -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declara=
tions -g  -Iinclude -I../include -D_REENTRANT -D_GNU_SOURCE  -O2 -march=3Di=
386   -DZAPTEL_OPTIMIZATIONS  -DASTERISK_VERSION=3D\"\" -DINSTALL_PREFIX=3D=
\"\" -DASTETCDIR=3D\"/etc/asterisk\" -DASTLIBDIR=3D\"/usr/lib/asterisk\" -D=
ASTVARLIBDIR=3D\"/var/lib/asterisk\" -DASTVARRUNDIR=3D\"/var/run/asterisk\"=
 -DASTSPOOLDIR=3D\"/var/spool/asterisk\" -DASTDATADIR=3D\"/usr/share/asteri=
sk\" -DASTLOGDIR=3D\"/var/log/asterisk\" -DASTCONFPATH=3D\"/etc/asterisk/as=
terisk.conf\" -DASTMODDIR=3D\"/usr/lib/asterisk/modules\" -DASTAGIDIR=3D\"/=
usr/share/asterisk/agi-bin\"     -DBUSYDETECT_MARTIN        -c -o channel.o=
 channel.c
channel.c:64: error: static declaration of 'uniquelock' follows non-static =
declaration
include/asterisk/channel.h:58: error: previous declaration of 'uniquelock' =
was here
make[1]: *** [channel.o] Error 1
make[1]: Leaving directory `/tmp/buildd/asterisk-1.0.9.dfsg'
make: *** [build-arch-stamp] Error 2

The attached patch makes the definition in channel.c not use static.

--=20
Matt

--LSp5EJdfMPwZcMS1
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename=patch
Content-Transfer-Encoding: quoted-printable

diff -ru asterisk-1.0.9.dfsg/debian/patches/bristuff-0.2.0-RC8h.dpatch aste=
risk-1.0.9.dfsg.new/debian/patches/bristuff-0.2.0-RC8h.dpatch
--- asterisk-1.0.9.dfsg/debian/patches/bristuff-0.2.0-RC8h.dpatch       
2005-07-2=
0 09:21:01.000000000 -0700
+++ asterisk-1.0.9.dfsg.new/debian/patches/bristuff-0.2.0-RC8h.dpatch   2005-=
07-20 09:13:13.000000000 -0700
@@ -976,7 +976,7 @@
 +extern int ast_mainpid; /* provided by asterisk.c */
  static int shutting_down =3D 0;
  static int uniqueint =3D 0;
-+AST_MUTEX_DEFINE_STATIC(uniquelock);
++AST_MUTEX_DEFINE_EXPORTED(uniquelock);
 =20
  /* XXX Lock appropriately in more functions XXX */
 =20
diff -ru asterisk-1.0.9.dfsg/debian/patches/bristuff-0.2.0-RC8j.dpatch aste=
risk-1.0.9.dfsg.new/debian/patches/bristuff-0.2.0-RC8j.dpatch
--- asterisk-1.0.9.dfsg/debian/patches/bristuff-0.2.0-RC8j.dpatch       
2005-07-2=
0 09:21:01.000000000 -0700
+++ asterisk-1.0.9.dfsg.new/debian/patches/bristuff-0.2.0-RC8j.dpatch   2005-=
07-20 09:13:24.000000000 -0700
@@ -977,7 +977,7 @@
 +extern int ast_mainpid; /* provided by asterisk.c */
  static int shutting_down =3D 0;
  static int uniqueint =3D 0;
-+AST_MUTEX_DEFINE_STATIC(uniquelock);
++AST_MUTEX_DEFINE_EXPORTED(uniquelock);
 =20
  /* XXX Lock appropriately in more functions XXX */
 =20

--LSp5EJdfMPwZcMS1--

--vKFfOv5t3oGVpiF+
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)

iD8DBQFC3m4EfNdgYxVXvBARAvPsAJwNuBsWGgIEiE2Ci7jYWxGLmWnLSQCggErz
OUQBz7Iamncti4MldQHeKtM=
=sqZH
-----END PGP SIGNATURE-----

--vKFfOv5t3oGVpiF+--

---------------------------------------
Received: (at 318337-close) by bugs.debian.org; 29 Jul 2005 06:23:01 +0000
>From katie@xxxxxxxxxxxxxxxx Thu Jul 28 23:23:01 2005
Return-path: <katie@xxxxxxxxxxxxxxxx>
Received: from katie by spohr.debian.org with local (Exim 3.36 1 (Debian))
        id 1DyOB6-0006Fn-00; Thu, 28 Jul 2005 23:17:04 -0700
From: Mark Purcell <msp@xxxxxxxxxx>
To: 318337-close@xxxxxxxxxxxxxxx
X-Katie: $Revision: 1.56 $
Subject: Bug#318337: fixed in asterisk 1:1.0.9.dfsg-4
Message-Id: <E1DyOB6-0006Fn-00@xxxxxxxxxxxxxxxx>
Sender: Archive Administrator <katie@xxxxxxxxxxxxxxxx>
Date: Thu, 28 Jul 2005 23:17:04 -0700
Delivered-To: 318337-close@xxxxxxxxxxxxxxx
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02 
        (1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Level: 
X-Spam-Status: No, hits=-6.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER 
        autolearn=no version=2.60-bugs.debian.org_2005_01_02

Source: asterisk
Source-Version: 1:1.0.9.dfsg-4

We believe that the bug you reported is fixed in the latest version of
asterisk, which is due to be installed in the Debian FTP archive:

asterisk-config_1.0.9.dfsg-4_all.deb
  to pool/main/a/asterisk/asterisk-config_1.0.9.dfsg-4_all.deb
asterisk-dev_1.0.9.dfsg-4_all.deb
  to pool/main/a/asterisk/asterisk-dev_1.0.9.dfsg-4_all.deb
asterisk-doc_1.0.9.dfsg-4_all.deb
  to pool/main/a/asterisk/asterisk-doc_1.0.9.dfsg-4_all.deb
asterisk-gtk-console_1.0.9.dfsg-4_i386.deb
  to pool/main/a/asterisk/asterisk-gtk-console_1.0.9.dfsg-4_i386.deb
asterisk-h323_1.0.9.dfsg-4_i386.deb
  to pool/main/a/asterisk/asterisk-h323_1.0.9.dfsg-4_i386.deb
asterisk-sounds-main_1.0.9.dfsg-4_all.deb
  to pool/main/a/asterisk/asterisk-sounds-main_1.0.9.dfsg-4_all.deb
asterisk-web-vmail_1.0.9.dfsg-4_all.deb
  to pool/main/a/asterisk/asterisk-web-vmail_1.0.9.dfsg-4_all.deb
asterisk_1.0.9.dfsg-4.diff.gz
  to pool/main/a/asterisk/asterisk_1.0.9.dfsg-4.diff.gz
asterisk_1.0.9.dfsg-4.dsc
  to pool/main/a/asterisk/asterisk_1.0.9.dfsg-4.dsc
asterisk_1.0.9.dfsg-4_i386.deb
  to pool/main/a/asterisk/asterisk_1.0.9.dfsg-4_i386.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 318337@xxxxxxxxxxxxxxx,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Mark Purcell <msp@xxxxxxxxxx> (supplier of updated asterisk package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@xxxxxxxxxx)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Fri, 22 Jul 2005 10:28:15 +1000
Source: asterisk
Binary: asterisk-sounds-main asterisk-h323 asterisk-web-vmail 
asterisk-gtk-console asterisk asterisk-config asterisk-dev asterisk-doc
Architecture: source all i386
Version: 1:1.0.9.dfsg-4
Distribution: unstable
Urgency: low
Maintainer: Debian VoIP Team <pkg-voip-maintainers@xxxxxxxxxxxxxxxxxxxxxxx>
Changed-By: Mark Purcell <msp@xxxxxxxxxx>
Description: 
 asterisk   - open source Private Branch Exchange (PBX)
 asterisk-config - config files for asterisk
 asterisk-dev - development files for asterisk
 asterisk-doc - documentation for asterisk
 asterisk-gtk-console - gtk based console for asterisk
 asterisk-h323 - asterisk H.323 VoIP channel
 asterisk-sounds-main - sound files for asterisk
 asterisk-web-vmail - web based (GCI) voice mail interface for asterisk
Closes: 318337
Changes: 
 asterisk (1:1.0.9.dfsg-4) unstable; urgency=low
 .
   * Cleanup bristuff to build under gcc4, thanks for the suggestions
     - Closes: #318337: FTBFS. channel.c:64: error: static declaration of
     'uniquelock' follows non-static declaration
Files: 
 3926a42bc0c9a5710d251757f16e53db 1257 comm optional asterisk_1.0.9.dfsg-4.dsc
 e3ef85d494d4fa7fbb8383d4ccf3da26 122376 comm optional 
asterisk_1.0.9.dfsg-4.diff.gz
 11774d350550462aaf212fdf6e6ffd63 1895202 doc optional 
asterisk-doc_1.0.9.dfsg-4_all.deb
 c0bbc88e17f7ec93dadffaf9549bd698 85474 devel optional 
asterisk-dev_1.0.9.dfsg-4_all.deb
 d89cf83f1b79fd07774444ea44984e16 1183048 comm optional 
asterisk-sounds-main_1.0.9.dfsg-4_all.deb
 0bd6b69589e6ee2fc7e57e3132c491a4 29592 comm optional 
asterisk-web-vmail_1.0.9.dfsg-4_all.deb
 1d70618616b06477e57c6f54f0f0b88b 63796 comm optional 
asterisk-config_1.0.9.dfsg-4_all.deb
 3f084a2a48e5fb2996371173af0feb7a 1189136 comm optional 
asterisk_1.0.9.dfsg-4_i386.deb
 684266338b748a258356179279995750 22782 comm optional 
asterisk-h323_1.0.9.dfsg-4_i386.deb
 a215cb49a6a1fbac12d5032af539c043 30956 comm optional 
asterisk-gtk-console_1.0.9.dfsg-4_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)

iD8DBQFC4D79oCzanz0IthIRAifdAJoDiEExzNEam97rfibaznvEvhQHhgCglmMr
sOZlyNbAUlj/DSBF30uMOpg=
=5ZQj
-----END PGP SIGNATURE-----