Bug#498057: devscripts: [uscan] Exit status is always zero, contradicting the manpage

Package: devscripts
Version: 2.10.35
Severity: normal

I give all options I'm using, in case it matters:
================================================================================
$ uscan --no-conf --download --no-symlink --upstream-version=3.0.1 
  --watchfile=/tmp/watchfile --package=octave
octave: Newer version (3.0.2) available on remote site:
  ftp://ftp.cs.tu-berlin.de/pub/gnu/octave/octave-3.0.2.tar.gz
  (local version is 3.0.1)
octave: Successfully downloaded updated package octave-3.0.2.tar.gz
weber@atlan:/tmp/s$ echo $?
0
================================================================================

Okay, so exit code 0 when a newer version is downloaded



================================================================================
$ uscan --no-conf --verbose --download --no-symlink --upstream-version=3.0.2 
  --watchfile=/tmp/watchfile --package=octave
-- In /tmp/watchfile, processing watchfile line:
   opts=pasv ftp://ftp.cs.tu-berlin.de/pub/gnu/octave/octave-([\d\.]+)\.tar\.gz
-- Found the following matching files:
     octave-3.0.0.tar.gz
     octave-3.0.1.tar.gz
     octave-3.0.2.tar.gz
Newest version on remote site is 3.0.2, local version is 3.0.2
 => Package is up to date
weber@atlan:/tmp/s$ echo $?
0
================================================================================

Newer package was downloaded, but still exit code 0. 

I attach a patch that fixes this thing for me, but you'd better check this
carefully. Watchfile attached.

Thanks
        Thomas


-- Package-specific info:

--- /etc/devscripts.conf ---

--- ~/.devscripts ---
Not present

-- System Information:
Debian Release: lenny/sid
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.26-1-amd64 (SMP w/2 CPU cores)
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages devscripts depends on:
ii  dpkg-dev                      1.14.20    Debian package development tools
ii  libc6                         2.7-13     GNU C Library: Shared libraries
ii  perl                          5.10.0-13  Larry Wall's Practical Extraction 

Versions of packages devscripts recommends:
ii  at                 3.1.10.1              Delayed job execution and batch pr
ii  bsd-mailx [mailx]  8.1.2-0.20071201cvs-3 A simple mail user agent
ii  cvs                1:1.12.13-11          Concurrent Versions System
ii  dctrl-tools        2.13.0                Command-line tools to process Debi
ii  debian-keyring     2008.07.22            GnuPG (and obsolete PGP) keys of D
ii  debian-maintainers 1.42                  GPG keys of Debian maintainers
ii  dput               0.9.2.32              Debian package upload tool
ii  dupload            2.6.4                 utility to upload Debian packages
ii  epiphany-gecko [ww 2.22.3-1              Intuitive GNOME web browser - Geck
ii  equivs             2.0.7-0.1             Circumvent Debian package dependen
ii  fakeroot           1.9.5                 Gives a fake root environment
ii  gnupg              1.4.9-3               GNU privacy guard - a free PGP rep
ii  iceweasel [www-bro 3.0.1-1               lightweight web browser based on M
ii  konqueror [www-bro 4:3.5.9.dfsg.1-5      KDE's advanced file manager, web b
ii  libauthen-sasl-per 2.12-1                Authen::SASL - SASL Authentication
ii  libcrypt-ssleay-pe 0.57-1+b1             Support for https protocol in LWP
ii  libparse-debcontro 2.005-2               Easy OO parsing of Debian control-
ii  libsoap-lite-perl  0.710.08-1            Client and server side SOAP implem
ii  libterm-size-perl  0.2-4+b1              Perl extension for retrieving term
ii  libtimedate-perl   1.1600-9              Time and date functions for Perl
ii  liburi-perl        1.35.dfsg.1-1         Manipulates and accesses URI strin
ii  libwww-perl        5.813-1               WWW client/server library for Perl
ii  libyaml-syck-perl  1.05-1                Fast, lightweight YAML loader and 
ii  lintian            1.24.2.1              Debian package checker
ii  lsb-release        3.2-19                Linux Standard Base version report
ii  lynx-cur [www-brow 2.8.7dev9-1.2         Text-mode WWW Browser with NLS sup
ii  man-db             2.5.2-2               on-line manual pager
ii  mercurial          1.0.1-3               Scalable distributed version contr
ii  openssh-client [ss 1:5.1p1-2             secure shell client, an rlogin/rsh
ii  patch              2.5.9-5               Apply a diff file to an original
ii  patchutils         0.2.31-4              Utilities to work with patches
ii  strace             4.5.17+cvs080723-2    A system call tracer
ii  subversion         1.5.1dfsg1-1          Advanced version control system
ii  unzip              5.52-12               De-archiver for .zip files
ii  w3m [www-browser]  0.5.2-2+b1            WWW browsable pager with excellent
ii  wdiff              0.5-18                Compares two files word by word
ii  wget               1.11.4-1              retrieves files from the web

Versions of packages devscripts suggests:
ii  build-essential               11.4       Informational list of build-essent
pn  cvs-buildpackage              <none>     (no description available)
pn  devscripts-el                 <none>     (no description available)
ii  gnuplot                       4.2.2-1.1  A command-line driven interactive 
pn  libfile-desktopentry-perl     <none>     (no description available)
pn  libnet-smtp-ssl-perl          <none>     (no description available)
ii  mutt                          1.5.18-4   text-based mailreader supporting M
pn  svn-buildpackage              <none>     (no description available)

-- no debconf information

watchfile
Description: Text document