Subject: [PATCH] 64bit support in test - msg#00232

Previous Message by Date: click to view message preview

[PATCH] bug in find_real_root_device.c and code clean up

Hi, after a couple hours of sleep I've put togheter a patch. This patch is useful for: 1) remove an unused var from extern char *find_real_root_device_name(const char* name) changing it to extern char *find_real_root_device_name(void). 2) fixes include/libbb.h, coreutils/df.c, util-linux/mount.c and util-linux/umount.c accordingly. 3) fixes a bug, really a false positive, in find_real_root_device_name() that happens if in the /dev directory exists a link named root (/dev/root) that should be skipped but is not. This affects applets like df that display wrong results like #./busybox df Filesystem 1k-blocks Used Available Use% Mounted on /dev/root 4024188 148408 3671356 4% / /dev/hdb3 4032124 41216 3786080 1% /home rather than # ./busybox df Filesystem 1k-blocks Used Available Use% Mounted on /dev/hdb1 4024188 148408 3671356 4% / /dev/hdb3 4032124 41216 3786080 1% /home Same thing for ./busybox mount. Please apply. Thanks in advance and ciao Tito find_root_device_patch.txt Description: Text document _______________________________________________ busybox mailing list busybox@xxxxxxxxxxxxxxxx http://codepoet.org/mailman/listinfo/busybox

Next Message by Date: click to view message preview

compiler warning about redefined

symbols in ash.c Date: Wed, 28 Jul 2004 12:03:07 +0000 User-Agent: KMail/1.6.1 MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Message-Id: <200407281203.07300.farmatito@xxxxxxxxxx> Status: R X-Status: NQ X-KMail-EncryptionState: X-KMail-SignatureState: X-KMail-MDN-Sent: Hi, while compiling rc2 i get the following warnings: shell/ash.c:215:1: warning: "barrier" redefined In file included from /usr/include/linux/compiler-gcc3.h:4, from /usr/include/linux/compiler.h:16, from /usr/include/asm/sigcontext.h:4, from /usr/include/bits/sigcontext.h:28, from /usr/include/signal.h:326, from /usr/include/sys/wait.h:30, from shell/ash.c:75: /usr/include/linux/compiler-gcc.h:10:1: warning: this is the location of the previous definition shell/ash.c:627:1: warning: "likely" redefined In file included from /usr/include/asm/sigcontext.h:4, from /usr/include/bits/sigcontext.h:28, from /usr/include/signal.h:326, from /usr/include/sys/wait.h:30, from shell/ash.c:75: /usr/include/linux/compiler.h:37:1: warning: this is the location of the previous definition My gcc is: gcc-3.3.2 (GCC) 3.3.2 (Mandrake Linux 10.0 3.3.2-6mdk) Ciao, Tito _______________________________________________ busybox mailing list busybox@xxxxxxxxxxxxxxxx http://codepoet.org/mailman/listinfo/busybox

Previous Message by Thread: click to view message preview

[PATCH] bug in find_real_root_device.c and code clean up

Hi, after a couple hours of sleep I've put togheter a patch. This patch is useful for: 1) remove an unused var from extern char *find_real_root_device_name(const char* name) changing it to extern char *find_real_root_device_name(void). 2) fixes include/libbb.h, coreutils/df.c, util-linux/mount.c and util-linux/umount.c accordingly. 3) fixes a bug, really a false positive, in find_real_root_device_name() that happens if in the /dev directory exists a link named root (/dev/root) that should be skipped but is not. This affects applets like df that display wrong results like #./busybox df Filesystem 1k-blocks Used Available Use% Mounted on /dev/root 4024188 148408 3671356 4% / /dev/hdb3 4032124 41216 3786080 1% /home rather than # ./busybox df Filesystem 1k-blocks Used Available Use% Mounted on /dev/hdb1 4024188 148408 3671356 4% / /dev/hdb3 4032124 41216 3786080 1% /home Same thing for ./busybox mount. Please apply. Thanks in advance and ciao Tito find_root_device_patch.txt Description: Text document _______________________________________________ busybox mailing list busybox@xxxxxxxxxxxxxxxx http://codepoet.org/mailman/listinfo/busybox

Next Message by Thread: click to view message preview

compiler warning about redefined

symbols in ash.c Date: Wed, 28 Jul 2004 12:03:07 +0000 User-Agent: KMail/1.6.1 MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Message-Id: <200407281203.07300.farmatito@xxxxxxxxxx> Status: R X-Status: NQ X-KMail-EncryptionState: X-KMail-SignatureState: X-KMail-MDN-Sent: Hi, while compiling rc2 i get the following warnings: shell/ash.c:215:1: warning: "barrier" redefined In file included from /usr/include/linux/compiler-gcc3.h:4, from /usr/include/linux/compiler.h:16, from /usr/include/asm/sigcontext.h:4, from /usr/include/bits/sigcontext.h:28, from /usr/include/signal.h:326, from /usr/include/sys/wait.h:30, from shell/ash.c:75: /usr/include/linux/compiler-gcc.h:10:1: warning: this is the location of the previous definition shell/ash.c:627:1: warning: "likely" redefined In file included from /usr/include/asm/sigcontext.h:4, from /usr/include/bits/sigcontext.h:28, from /usr/include/signal.h:326, from /usr/include/sys/wait.h:30, from shell/ash.c:75: /usr/include/linux/compiler.h:37:1: warning: this is the location of the previous definition My gcc is: gcc-3.3.2 (GCC) 3.3.2 (Mandrake Linux 10.0 3.3.2-6mdk) Ciao, Tito _______________________________________________ busybox mailing list busybox@xxxxxxxxxxxxxxxx http://codepoet.org/mailman/listinfo/busybox