logo       

Re: patch to login, dmesg and obscure: msg#00215

linux.busybox

Subject: Re: patch to login, dmesg and obscure

Ronny,


wrapped have size(old) * 2 +1. This can`t overflow for rotate check.




Are you realy sure?? Becuse some lines down ther's a
strcat(wrapped, wrapped)
instruction where the actual overflow occure.

Example:

old = "123" (4 bytes)
wrapped allocated = 3*2 + 1 = 7 bytes.
first initialisez only 4 bytes = "123"
after strcat resut is "123123" - 7 bytes.
Not overflow.


--w
vodz


<Prev in Thread] Current Thread [Next in Thread>
Google Custom Search

News | FAQ | advertise