logo       

Re: how to do inquiry with RSSI in bluetooth 1.2 devices?: msg#00080

linux.bluez.devel

Subject: Re: how to do inquiry with RSSI in bluetooth 1.2 devices?

Hi Albert,

> > Attached is a patch for bluez-libs. Two functions are added.
>
> please ignore previous message. That patch doesn't follow the
> naming/tabbing conventions in the rest of bluez-libs. Attached is a
> patch that does.

the coding style is still not correct and you screwed the patch up by
inserting memset() that overrides previous set values. Besides this you
set the rq.rlen wrong.

I implemented the hci_{read|write}_inquiry_mode() functions by myself
and also changed hciconfig to use them. My version is not so different
from yours, but the details matter. Please compare them and start
sending in more patches to enhance the Bluetooth library.

Regards

Marcel




-------------------------------------------------------
This SF.net email is sponsored by: IT Product Guide on ITManagersJournal
Use IT products in your business? Tell us what you think of them. Give us
Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more
http://productguide.itmanagersjournal.com/guidepromo.tmpl


<Prev in Thread] Current Thread [Next in Thread>
Google Custom Search

News | FAQ | advertise