Re: [ath5k-devel] [PATCH 4/4] ath5k: Use SWI to trigger calibration

2009/7/31 Bob Copeland <me@xxxxxxxxxxxxxxx>:
> On Fri, Jul 31, 2009 at 2:25 PM, Nick Kossifidis<mickflemm@xxxxxxxxx> wrote:
>> Â ÂAlso we don't need to run calibration if we are idle (no interrupts).
>
> I think this is the big win right now...
>
>> c) Having calibration on a tasklet is better since during calibration
>> Â Âwe can't transmit or receive (antennas are detached to measure
>> Â Ânoise floor), previously calibration could run in parallel with tx/rx
>> Â Âand interfere (packet loss).
>
> This can still happen, no? ÂTwo tasklets can run in parallel on
> different processors, as long as they are different tasklets.
>
> In practice, this won't happen much because tasklets run on the
> cpu that scheduled them, and irq affinity is such (at least on my
> hardware) that it's almost always the same CPU. ÂBut I think to
> make the above true it needs to stop the queues etc when doing
> calibration.
>

ACK, how do we do that ?
ieee80211_stop_queues / ieee80211_wake_queues

> Also we are missing tasklet_kill()?
>

Yup, resending...



-- 
GPG ID: 0xD21DB2DB
As you read this post global entropy rises. Have Fun ;-)
Nick
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html