Re: [ath5k-devel] [PATCH 4/4] ath5k: Use SWI to trigger calibration

On Fri, Jul 31, 2009 at 2:25 PM, Nick Kossifidis<mickflemm@xxxxxxxxx> wrote:
>    Also we don't need to run calibration if we are idle (no interrupts).

I think this is the big win right now...

> c) Having calibration on a tasklet is better since during calibration
>    we can't transmit or receive (antennas are detached to measure
>    noise floor), previously calibration could run in parallel with tx/rx
>    and interfere (packet loss).

This can still happen, no?  Two tasklets can run in parallel on
different processors, as long as they are different tasklets.

In practice, this won't happen much because tasklets run on the
cpu that scheduled them, and irq affinity is such (at least on my
hardware) that it's almost always the same CPU.  But I think to
make the above true it needs to stop the queues etc when doing
calibration.

Also we are missing tasklet_kill()?

-- 
Bob Copeland %% www.bobcopeland.com
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html