Re: [ath5k-devel] [PATCH 4/4] ath5k: Use SWI to trigger calibration

On Fri, Jul 31, 2009 at 11:25 AM, Nick Kossifidis<mickflemm@xxxxxxxxx> wrote:
> 2009/7/31 Luis R. Rodriguez <mcgrof@xxxxxxxxx>:
>> On Fri, Jul 31, 2009 at 11:10 AM, Nick
>> Kossifidis<mick@xxxxxxxxxxxxxxxxxxx> wrote:
>>> Â* Get rid of calibration timer, instead use a software interrupt
>>> Â to schedule the calibration tasklet.
>>
>> An example of itemizing one change. Explain the why, not the how.
>>
>
> We 've discussed this with various people on wireless summit.

Not everyone attended.

> a) We don't need a timer for this, there is no need for accuracy
> Â Âeven with round_jiffies i think this is a waste of resources.
> Â ÂAlso we don't need to run calibration if we are idle (no interrupts).
>
> b) When we add ANI support we 'll just extend the poll function
> Â Âand calibration tasklet and handle all periodic phy calibration
> Â Âon one place (much cleaner).
>
> c) Having calibration on a tasklet is better since during calibration
> Â Âwe can't transmit or receive (antennas are detached to measure
> Â Ânoise floor), previously calibration could run in parallel with tx/rx
> Â Âand interfere (packet loss).

It seems this good explanation can be mangled into the commit log entry.

  Luis
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html