logo       

Re: [PATCH 3/4] ath5k: Wakeup fixes: msg#01603

linux-wireless

Subject: Re: [PATCH 3/4] ath5k: Wakeup fixes

2009/7/31 Luis R. Rodriguez <mcgrof@xxxxxxxxx>:
> On Fri, Jul 31, 2009 at 11:08 AM, Nick
> Kossifidis<mick@xxxxxxxxxxxxxxxxxxx> wrote:
>> Â* Don't put chip to full sleep because there are problems during
>> Â wakeup. Instead hold MAC/Baseband on warm reset state via a new
>> Â function ath5k_hw_on_hold.
>>
>> Â* Durring attach preserve pcicfg bits when enabling pci core
>> Â sw retry fix.
>>
>> Â* Minor cleanups
>
> Can you address these changes separately? I see you tend to itemize
> the things you change, even when you just make one change. Please
> consider addressing one change per commit and just ensure the why is
> crystal clear.
>
> ÂLuis
>

Cleanup doesn't count as a change, the only real change is the first one.
I 'm trying not to pollute the logs. This patch fixes an issue reported when
card doesn't wake up.

--
GPG ID: 0xD21DB2DB
As you read this post global entropy rises. Have Fun ;-)
Nick
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html

Google Custom Search

News | Mail Home | sitemap | FAQ | advertise