logo       

Re: [PATCH] compat-2.6: Makefile: fixed test expressions for target instal: msg#01524

linux-wireless

Subject: Re: [PATCH] compat-2.6: Makefile: fixed test expressions for target install

On Thu, 2009-07-30 at 23:25 +0200, Joerg Albert wrote:
> This removes the two errors of [ with target "install"
>
> make[1]: Leaving directory `/home/joerg/src/linux-2.6.30'
> [: 9: missing ]
> [: 9: missing ]
> depmod will prefer updates/ over kernel/ -- OK!

I believe "-a" in test is not very portable. I remember getting
complaints about it. I believe the built-in test command in bash 1.x
doesn't have it. I'd rather stick with && and || written properly.

"-a" and -o" are currently only used in the clean target and in the
maintenance scripts, so they probably don't get enough testing on
systems with old bash.

--
Regards,
Pavel Roskin
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html

Google Custom Search

News | Mail Home | sitemap | FAQ | advertise